Re: Re: [PATCH V4 5/5] ARM: EXYNOS4: Add platform data for EXYNOS4

Hi, Mythri.

-----Original Message-----
From: linux-fbdev-owner@vger.kernel.org [mailto:linux-fbdev-
owner@vger.kernel.org] On Behalf Of K, Mythri P
Sent: Thursday, June 23, 2011 6:04 PM
To: jg1.han@samsung.com
Cc: Kukjin Kim; Paul Mundt; linux-samsung-soc@vger.kernel.org; linux-
fbdev@vger.kernel.org; Jong-Hun Han; ANAND KUMAR N; Sylwester Nawrocki;
THOMAS P ABRAHAM; Marek Szyprowski; Kyungmin Park; In-Ki Dae; ARM Linux;
Ben Dooks
Subject: Re: [PATCH V4 5/5] ARM: EXYNOS4: Add platform data for EXYNOS4
FIMD and LTE480WV platform-lcd

2011/6/22 JinGoo Han [off-list ref]:

quoted

From: Jonghun Han <redacted>

This patch adds support EXYNOS4 FIMD0 and LTE480WV LCD pannel.

Signed-off-by: Jonghun Han <redacted>
Signed-off-by: Jingoo Han <redacted>
---
 arch/arm/mach-exynos4/mach-smdkc210.c |  114

+++++++++++++++++++++++++++++++++

quoted

 arch/arm/mach-exynos4/mach-smdkv310.c |  114

+++++++++++++++++++++++++++++++++

quoted

 2 files changed, 228 insertions(+), 0 deletions(-)

<<snip>>

quoted

+static void lcd_lte480wv_set_power(struct plat_lcd_data *pd,
+                                  unsigned int power)
+{
+       if (power) {
+#if !defined(CONFIG_BACKLIGHT_PWM)
+               gpio_request(EXYNOS4_GPD0(1), "GPD0");
+               gpio_direction_output(EXYNOS4_GPD0(1), 1);
+               gpio_free(EXYNOS4_GPD0(1));
+#endif
+               /* fire nRESET on power up */
+               gpio_request(EXYNOS4_GPX0(6), "GPX0");
+
+               gpio_direction_output(EXYNOS4_GPX0(6), 1);
+               mdelay(100);
+
+               gpio_set_value(EXYNOS4_GPX0(6), 0);
+               mdelay(10);
+
+               gpio_set_value(EXYNOS4_GPX0(6), 1);
+               mdelay(10);
+
+               gpio_free(EXYNOS4_GPX0(6));
+       } else {
+#if !defined(CONFIG_BACKLIGHT_PWM)
+               gpio_request(EXYNOS4_GPD0(1), "GPD0");
+               gpio_direction_output(EXYNOS4_GPD0(1), 0);
+               gpio_free(EXYNOS4_GPD0(1));
+#endif
+       }
+}
+

have you considered using gpio_request_one instead ? It simplifies the
three step API.

You're right. It seems to be very helpful.
I will apply it and send V7 patches, soon.
Thank you for your reply.

<<snip>>

quoted

+       if (power) {
+#if !defined(CONFIG_BACKLIGHT_PWM)
+               gpio_request(EXYNOS4_GPD0(1), "GPD0");
+               gpio_direction_output(EXYNOS4_GPD0(1), 1);
+               gpio_free(EXYNOS4_GPD0(1));
+#endif
+               /* fire nRESET on power up */
+               gpio_request(EXYNOS4_GPX0(6), "GPX0");
+
+               gpio_direction_output(EXYNOS4_GPX0(6), 1);
+               mdelay(100);
+
+               gpio_set_value(EXYNOS4_GPX0(6), 0);
+               mdelay(10);
+
+               gpio_set_value(EXYNOS4_GPX0(6), 1);
+               mdelay(10);
+
+               gpio_free(EXYNOS4_GPX0(6));
+       } else {
+#if !defined(CONFIG_BACKLIGHT_PWM)
+               gpio_request(EXYNOS4_GPD0(1), "GPD0");
+               gpio_direction_output(EXYNOS4_GPD0(1), 0);
+               gpio_free(EXYNOS4_GPD0(1));
+#endif
+       }
+}

same comment as above.

<<snip>>



--
Thanks and regards,
Mythri.
--
To unsubscribe from this list: send the line "unsubscribe linux-fbdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

ÿôèº{.nÇ+‰·Ÿ®‰­†+%ŠËÿ±éݶ¥Šwÿº{.nÇ+‰·¥Š{±ıöİzÿâ�Ø^n‡r¡ö¦zË�ëh™¨è­Ú&£ûàz¿äz¹Ş—ú+€Ê+zf£¢·hšˆ§~†­†Ûiÿÿï�êÿ‘êçz_è®æj:+v‰¨ş)ߣøm