# \[PATCH 18/37\] Remove unneeded version.h includes from drivers/video/

- Subsystems: FRAMEBUFFER LAYER, ADP8860 BACKLIGHT DRIVER (ADP8860/ADP8861/ADP8863), BACKLIGHT CLASS/SUBSYSTEM, THE REST
- Maintainers: Helge Deller, Michael Hennerich, Lee Jones, Daniel Thompson, Jingoo Han, Linus Torvalds
- List: linux-fbdev
- 3 messages, 3 authors
- Page: https://ratatoskr.run/linux-fbdev/2011/06/3733683/t

## \[PATCH 18/37\] Remove unneeded version.h includes from drivers/video/

- From: Jesper Juhl \<hidden\>
- Date: 2011-06-23 22:44:14 
- Message: https://ratatoskr.run/linux-fbdev/2011/06/3733683.md

```text
It was pointed out by 'make versioncheck' that some includes of
linux/version.h are not needed in drivers/video/.
This patch removes them.

Signed-off-by: Jesper Juhl <redacted>
---
 drivers/video/backlight/adp8860_bl.c |    1 -
 drivers/video/backlight/adp8870_bl.c |    1 -
 drivers/video/pxa3xx-gcu.c           |    2 --
 drivers/video/xilinxfb.c             |    1 -
 4 files changed, 0 insertions(+), 5 deletions(-)

diff --git a/drivers/video/backlight/adp8860_bl.c b/drivers/video/backlight/adp8860_bl.c
index d2a96a4..24a6dfd 100644
--- a/drivers/video/backlight/adp8860_bl.c
+++ b/drivers/video/backlight/adp8860_bl.c
@@ -7,7 +7,6 @@
  */
 
 #include <linux/module.h>
-#include <linux/version.h>
 #include <linux/init.h>
 #include <linux/errno.h>
 #include <linux/pm.h>
diff --git a/drivers/video/backlight/adp8870_bl.c b/drivers/video/backlight/adp8870_bl.c
index 05a8832..383c4c3 100644
--- a/drivers/video/backlight/adp8870_bl.c
+++ b/drivers/video/backlight/adp8870_bl.c
@@ -7,7 +7,6 @@
  */
 
 #include <linux/module.h>
-#include <linux/version.h>
 #include <linux/init.h>
 #include <linux/errno.h>
 #include <linux/pm.h>
diff --git a/drivers/video/pxa3xx-gcu.c b/drivers/video/pxa3xx-gcu.c
index 0283c70..d8de557 100644
--- a/drivers/video/pxa3xx-gcu.c
+++ b/drivers/video/pxa3xx-gcu.c
@@ -31,8 +31,6 @@
  */
 
 #include <linux/module.h>
-#include <linux/version.h>
-
 #include <linux/platform_device.h>
 #include <linux/dma-mapping.h>
 #include <linux/miscdevice.h>
diff --git a/drivers/video/xilinxfb.c b/drivers/video/xilinxfb.c
index 77dea01..fcb6cd9 100644
--- a/drivers/video/xilinxfb.c
+++ b/drivers/video/xilinxfb.c
@@ -23,7 +23,6 @@
 #include <linux/device.h>
 #include <linux/module.h>
 #include <linux/kernel.h>
-#include <linux/version.h>
 #include <linux/errno.h>
 #include <linux/string.h>
 #include <linux/mm.h>
-- 
1.7.5.2


-- 
Jesper Juhl <jj@chaosbits.net>       http://www.chaosbits.net/
Don't top-post http://www.catb.org/jargon/html/T/top-post.html
Plain text mails only, please.

```

## Re: \[PATCH 18/37\] Remove unneeded version.h includes from drivers/video/

- From: Mike Frysinger \<hidden\>
- Date: 2011-06-23 22:51:26 
- Message: https://ratatoskr.run/linux-fbdev/2011/06/3733695.md

```text
On Thu, Jun 23, 2011 at 18:35, Jesper Juhl wrote:
>  drivers/video/backlight/adp8860_bl.c |    1 -
>  drivers/video/backlight/adp8870_bl.c |    1 -

Acked-by: Mike Frysinger <redacted>
-mike
```

## Re: \[PATCH 18/37\] Remove unneeded version.h includes from drivers/video/

- From: Paul Mundt \<hidden\>
- Date: 2011-06-24 08:18:21 
- Message: https://ratatoskr.run/linux-fbdev/2011/06/3733831.md

```text
On Fri, Jun 24, 2011 at 12:35:17AM +0200, Jesper Juhl wrote:
> It was pointed out by 'make versioncheck' that some includes of
> linux/version.h are not needed in drivers/video/.
> This patch removes them.
> 
> Signed-off-by: Jesper Juhl <redacted>
> ---
>  drivers/video/backlight/adp8860_bl.c |    1 -
>  drivers/video/backlight/adp8870_bl.c |    1 -
>  drivers/video/pxa3xx-gcu.c           |    2 --
>  drivers/video/xilinxfb.c             |    1 -
>  4 files changed, 0 insertions(+), 5 deletions(-)
> 
Applied, thanks.
```