# \[PATCH\] EFIFB: Fix error handling - Subsystems: FRAMEBUFFER LAYER, THE REST - Maintainers: Helge Deller, Linus Torvalds - List: linux-fbdev - 2 messages, 2 authors - Page: https://ratatoskr.run/linux-fbdev/2011/06/3729301/t ## \[PATCH\] EFIFB: Fix error handling - From: David Howells \ - Date: 2011-06-15 00:39:39 - Message: https://ratatoskr.run/linux-fbdev/2011/06/3729301.md ```text Fix the error handling in the EFIFB driver if platform_driver_probe() fails. In that case, the code will pass the driver struct to the _device_ unregistration function. It presumably should pass a pointer to the device struct instead. The compiler gives the following warning to indicate this: drivers/video/efifb.c: In function 'efifb_init': drivers/video/efifb.c:544:3: warning: passing argument 1 of 'platform_device_unregister' from incompatible pointer type include/linux/platform_device.h:40:13: note: expected 'struct platform_device *' but argument is of type 'struct platform_driver *' Signed-off-by: David Howells cc: Peter Jones cc: cc: stable@kernel.org --- drivers/video/efifb.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/video/efifb.c b/drivers/video/efifb.c index 69c49df..784139a 100644 --- a/drivers/video/efifb.c +++ b/drivers/video/efifb.c @@ -541,7 +541,7 @@ static int __init efifb_init(void) */ ret = platform_driver_probe(&efifb_driver, efifb_probe); if (ret) { - platform_device_unregister(&efifb_driver); + platform_device_unregister(&efifb_device); return ret; } ``` ## Re: \[PATCH\] EFIFB: Fix error handling - From: Paul Mundt \ - Date: 2011-06-15 02:38:38 - Message: https://ratatoskr.run/linux-fbdev/2011/06/3729332.md ```text On Wed, Jun 15, 2011 at 01:38:17AM +0100, David Howells wrote: > Fix the error handling in the EFIFB driver if platform_driver_probe() fails. > In that case, the code will pass the driver struct to the _device_ > unregistration function. It presumably should pass a pointer to the device > struct instead. > > The compiler gives the following warning to indicate this: > > drivers/video/efifb.c: In function 'efifb_init': > drivers/video/efifb.c:544:3: warning: passing argument 1 of 'platform_device_unregister' from incompatible pointer type > include/linux/platform_device.h:40:13: note: expected 'struct platform_device *' but argument is of type 'struct platform_driver *' > > Signed-off-by: David Howells > cc: Peter Jones > cc: > cc: stable@kernel.org Thanks, I've already queued a fix for this. ```