# \[PATCH v2 11/29\] hgafb: use display information in info not in var for panning - From: Laurent Pinchart \ - Date: 2011-06-14 09:24:49 - List: linux-fbdev - Page: https://ratatoskr.run/linux-fbdev/2011/06/13461650 - Thread: https://ratatoskr.run/linux-fbdev/2011/06/13461650/t.md ```text We must not use any information in the passed var besides xoffset, yoffset and vmode as otherwise applications might abuse it. Signed-off-by: Laurent Pinchart Cc: Ferenc Bakonyi Cc: Brent Cook --- drivers/video/hgafb.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/video/hgafb.c b/drivers/video/hgafb.c index 4052718..4394389 100644 --- a/drivers/video/hgafb.c +++ b/drivers/video/hgafb.c @@ -422,8 +422,8 @@ static int hgafb_pan_display(struct fb_var_screeninfo *var, var->xoffset) return -EINVAL; } else { - if (var->xoffset + var->xres > info->var.xres_virtual - || var->yoffset + var->yres > info->var.yres_virtual + if (var->xoffset + info->var.xres > info->var.xres_virtual + || var->yoffset + info->var.yres > info->var.yres_virtual || var->yoffset % 8) return -EINVAL; } -- 1.7.3.4 ```