# \[PATCH 10/29\] gxt4500: use display information in info not in var for panning - From: Laurent Pinchart \ - Date: 2011-05-25 22:58:02 - List: linux-fbdev - Page: https://ratatoskr.run/linux-fbdev/2011/05/13461384 - Thread: https://ratatoskr.run/linux-fbdev/2011/05/13461384/t.md ```text We must not use any information in the passed var besides xoffset, yoffset and vmode as otherwise applications might abuse it. Signed-off-by: Laurent Pinchart Cc: Paul Mackerras --- drivers/video/gxt4500.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/video/gxt4500.c b/drivers/video/gxt4500.c index 896e53d..0fad23f 100644 --- a/drivers/video/gxt4500.c +++ b/drivers/video/gxt4500.c @@ -543,8 +543,8 @@ static int gxt4500_pan_display(struct fb_var_screeninfo *var, if (var->xoffset & 7) return -EINVAL; - if (var->xoffset + var->xres > var->xres_virtual || - var->yoffset + var->yres > var->yres_virtual) + if (var->xoffset + info->var.xres > info->var.xres_virtual || + var->yoffset + info->var.yres > info->var.yres_virtual) return -EINVAL; writereg(par, REFRESH_START, (var->xoffset << 16) | var->yoffset); -- 1.7.3.4 ```