[PATCH 3/4] efifb: Fix an integer-to-pointer size warning

Subsystems: framebuffer layer, the rest

STALE5611d

3 messages, 2 authors, 2011-05-26 · open the first message on its own page

[PATCH 3/4] efifb: Fix an integer-to-pointer size warning

From: Andy Lutomirski <hidden>
Date: 2011-05-26 14:13:33

Signed-off-by: Andy Lutomirski <redacted>
---
 drivers/video/efifb.c |    5 +++--
 1 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/video/efifb.c b/drivers/video/efifb.c
index 43af770..39bbfa9 100644
--- a/drivers/video/efifb.c
+++ b/drivers/video/efifb.c
@@ -246,8 +246,9 @@ static int set_system(const struct dmi_system_id *id)
 
 	printk(KERN_INFO "efifb: dmi detected %s - framebuffer at %p "
 			 "(%dx%d, stride %d)\n", id->ident,
-			 (void *)screen_info.lfb_base, screen_info.lfb_width,
-			 screen_info.lfb_height, screen_info.lfb_linelength);
+			 (void *)(unsigned long)screen_info.lfb_base,
+			 screen_info.lfb_width, screen_info.lfb_height,
+			 screen_info.lfb_linelength);
 
 
 	return 1;
-- 
1.7.5.1

Re: [PATCH 3/4] efifb: Fix an integer-to-pointer size warning

From: Peter Jones <pjones@redhat.com>
Date: 2011-05-26 14:34:38

On 05/26/2011 10:13 AM, Andy Lutomirski wrote:
Signed-off-by: Andy Lutomirski <redacted>
Signed-off-by: Peter Jones <pjones@redhat.com>
quoted hunk
---
 drivers/video/efifb.c |    5 +++--
 1 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/video/efifb.c b/drivers/video/efifb.c
index 43af770..39bbfa9 100644
--- a/drivers/video/efifb.c
+++ b/drivers/video/efifb.c
@@ -246,8 +246,9 @@ static int set_system(const struct dmi_system_id *id)
 
 	printk(KERN_INFO "efifb: dmi detected %s - framebuffer at %p "
 			 "(%dx%d, stride %d)\n", id->ident,
-			 (void *)screen_info.lfb_base, screen_info.lfb_width,
-			 screen_info.lfb_height, screen_info.lfb_linelength);
+			 (void *)(unsigned long)screen_info.lfb_base,
+			 screen_info.lfb_width, screen_info.lfb_height,
+			 screen_info.lfb_linelength);
 
 
 	return 1;

-- 
        Peter

If you're not part of the solution, then you're part of the precipitate.

01234567890123456789012345678901234567890123456789012345678901234567890123456789

Re: [PATCH 3/4] efifb: Fix an integer-to-pointer size warning

From: Andrew Lutomirski <hidden>
Date: 2011-05-26 14:55:38

On Thu, May 26, 2011 at 10:34 AM, Peter Jones [off-list ref] wrote:
On 05/26/2011 10:13 AM, Andy Lutomirski wrote:
quoted
Signed-off-by: Andy Lutomirski <redacted>
Signed-off-by: Peter Jones <pjones@redhat.com>
I got beaten to the punch:

http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;hÜ3e5b6a6e842116ec2436161adf31877f09b6b9

Feel free to drop this patch.  The others should still be fine.

--Andy
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help