# Re: \[PATCH 27/29\] vt8500lcdfb: use display information in info not in

- From: Alexey Charkov \<alchark@gmail.com\>
- Date: 2011-05-26 03:54:26 
- List: linux-fbdev
- Page: https://ratatoskr.run/linux-fbdev/2011/05/13461304
- Thread: https://ratatoskr.run/linux-fbdev/2011/05/13461303/t.md

```text
2011/5/26 Laurent Pinchart [ref]:
> We must not use any information in the passed var besides xoffset,
> yoffset and vmode as otherwise applications might abuse it.

Agreed, thanks for the fix!

> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> Cc: Alexey Charkov <alchark@gmail.com>
> ---
>  drivers/video/vt8500lcdfb.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/video/vt8500lcdfb.c b/drivers/video/vt8500lcdfb.c
> index 0e120d6..c13c246 100644
> --- a/drivers/video/vt8500lcdfb.c
> +++ b/drivers/video/vt8500lcdfb.c
> @@ -210,8 +210,8 @@ static int vt8500lcd_pan_display(struct fb_var_screeninfo *var,
>        struct vt8500lcd_info *fbi = to_vt8500lcd_info(info);
>
>        writel((1 << 31)
> -               | (((var->xres_virtual - var->xres) * pixlen / 4) << 20)
> -               | (off >> 2), fbi->regbase + 0x20);
> +            | (((info->var.xres_virtual - info->var.xres) * pixlen / 4) << 20)
> +            | (off >> 2), fbi->regbase + 0x20);
>        return 0;
>  }
>
> --
> 1.7.3.4
>
>

Best regards,
Alexey
```