# \[PATCH 6/6\] drivers/video/bfin-lq035q1-fb.c: introduce missing kfree

- Subsystems: FRAMEBUFFER LAYER, THE REST
- Maintainers: Helge Deller, Linus Torvalds
- List: linux-fbdev
- 3 messages, 3 authors
- Page: https://ratatoskr.run/linux-fbdev/2011/04/3698046/t

## \[PATCH 6/6\] drivers/video/bfin-lq035q1-fb.c: introduce missing kfree

- From: Julia Lawall \<hidden\>
- Date: 2011-04-01 14:24:04 
- Message: https://ratatoskr.run/linux-fbdev/2011/04/3698046.md

```text
Error handling code following a kmalloc should free the allocated data.

The semantic match that finds the problem is as follows:
(http://www.emn.fr/x-info/coccinelle/)

// <smpl>
@r exists@
local idexpression x;
statement S;
expression E;
identifier f,f1,l;
position p1,p2;
expression *ptr != NULL;
@@

x@p1 = \(kmalloc\|kzalloc\|kcalloc\)(...);
...
if (x = NULL) S
<... when != x
     when != if (...) { <+...x...+> }
(
x->f1 = E
|
 (x->f1 = NULL || ...)
|
 f(...,x->f1,...)
)
...>
(
 return \(0\|<+...x...+>\|ptr\);
|
 return@p2 ...;
)

@script:python@
p1 << r.p1;
p2 << r.p2;
@@

print "* file: %s kmalloc %s return %s" % (p1[0].file,p1[0].line,p2[0].line)
// </smpl>

Signed-off-by: Julia Lawall <redacted>

---
 drivers/video/bfin-lq035q1-fb.c |    4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/video/bfin-lq035q1-fb.c b/drivers/video/bfin-lq035q1-fb.c
index c8e1f04..23b6c4b 100644
--- a/drivers/video/bfin-lq035q1-fb.c
+++ b/drivers/video/bfin-lq035q1-fb.c
@@ -154,8 +154,10 @@ static int __devinit lq035q1_spidev_probe(struct spi_device *spi)
 
 	ret = lq035q1_control(spi, LQ035_SHUT_CTL, LQ035_ON);
 	ret |= lq035q1_control(spi, LQ035_DRIVER_OUTPUT_CTL, ctl->mode);
-	if (ret)
+	if (ret) {
+		kfree(ctl);
 		return ret;
+	}
 
 	spi_set_drvdata(spi, ctl);
 

```

## Re: \[PATCH 6/6\] drivers/video/bfin-lq035q1-fb.c: introduce missing kfree

- From: Mike Frysinger \<hidden\>
- Date: 2011-04-02 05:12:09 
- Message: https://ratatoskr.run/linux-fbdev/2011/04/3698318.md

```text
On Fri, Apr 1, 2011 at 10:23, Julia Lawall wrote:
> Error handling code following a kmalloc should free the allocated data.

Acked-by: Mike Frysinger <redacted>
-mike
```

## Re: \[PATCH 6/6\] drivers/video/bfin-lq035q1-fb.c: introduce missing kfree

- From: Paul Mundt \<hidden\>
- Date: 2011-04-06 16:46:39 
- Message: https://ratatoskr.run/linux-fbdev/2011/04/3699685.md

```text
On Sat, Apr 02, 2011 at 01:05:57AM -0400, Mike Frysinger wrote:
> On Fri, Apr 1, 2011 at 10:23, Julia Lawall wrote:
> > Error handling code following a kmalloc should free the allocated data.
> 
> Acked-by: Mike Frysinger <redacted>

Applied, thanks.
```