# \[PATCH\] fbcon: Remove unused 'display \*p' variable from fb\_flashcursor()

- Subsystems: FRAMEBUFFER LAYER, CONSOLE SUBSYSTEM, THE REST
- Maintainers: Helge Deller, Greg Kroah-Hartman, Linus Torvalds
- List: linux-fbdev
- 3 messages, 3 authors
- Page: https://ratatoskr.run/linux-fbdev/2011/03/3694261/t

## \[PATCH\] fbcon: Remove unused 'display \*p' variable from fb\_flashcursor()

- From: Sergey Senozhatsky \<hidden\>
- Date: 2011-03-24 20:46:54 
- Message: https://ratatoskr.run/linux-fbdev/2011/03/3694261.md

```text
fbcon: Remove unused 'display *p' variable from fb_flashcursor()

Signed-of-by: Sergey Senozhatsky [ref]

---

 drivers/video/console/fbcon.c |    2 --
 1 files changed, 0 insertions(+), 2 deletions(-)

diff --git a/drivers/video/console/fbcon.c b/drivers/video/console/fbcon.c
index c583934..8745637 100644
--- a/drivers/video/console/fbcon.c
+++ b/drivers/video/console/fbcon.c
@@ -370,7 +370,6 @@ static void fb_flashcursor(struct work_struct *work)
 {
 	struct fb_info *info = container_of(work, struct fb_info, queue);
 	struct fbcon_ops *ops = info->fbcon_par;
-	struct display *p;
 	struct vc_data *vc = NULL;
 	int c;
 	int mode;
@@ -386,7 +385,6 @@ static void fb_flashcursor(struct work_struct *work)
 		return;
 	}
 
-	p = &fb_display[vc->vc_num];
 	c = scr_readw((u16 *) vc->vc_pos);
 	mode = (!ops->cursor_flash || ops->cursor_state.enable) ?
 		CM_ERASE : CM_DRAW;

```

## Re: \[PATCH\] fbcon: Remove unused 'display \*p' variable from fb\_flashcursor()

- From: Jesse Barnes \<hidden\>
- Date: 2011-03-28 16:18:57 
- Message: https://ratatoskr.run/linux-fbdev/2011/03/3695686.md

```text
On Thu, 24 Mar 2011 22:50:52 +0200
Sergey Senozhatsky [ref] wrote:

> fbcon: Remove unused 'display *p' variable from fb_flashcursor()
> 
> Signed-of-by: Sergey Senozhatsky [ref]
> 
> ---
> 
>  drivers/video/console/fbcon.c |    2 --
>  1 files changed, 0 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/video/console/fbcon.c b/drivers/video/console/fbcon.c
> index c583934..8745637 100644
> --- a/drivers/video/console/fbcon.c
> +++ b/drivers/video/console/fbcon.c
> @@ -370,7 +370,6 @@ static void fb_flashcursor(struct work_struct *work)
>  {
>  	struct fb_info *info = container_of(work, struct fb_info, queue);
>  	struct fbcon_ops *ops = info->fbcon_par;
> -	struct display *p;
>  	struct vc_data *vc = NULL;
>  	int c;
>  	int mode;
> @@ -386,7 +385,6 @@ static void fb_flashcursor(struct work_struct *work)
>  		return;
>  	}
>  
> -	p = &fb_display[vc->vc_num];
>  	c = scr_readw((u16 *) vc->vc_pos);
>  	mode = (!ops->cursor_flash || ops->cursor_state.enable) ?
>  		CM_ERASE : CM_DRAW;

Looks fine to me, is Paul the lucky owner of fbdev now?

-- 
Jesse Barnes, Intel Open Source Technology Center
```

## Re: \[PATCH\] fbcon: Remove unused 'display \*p' variable from fb\_flashcursor()

- From: Paul Mundt \<hidden\>
- Date: 2011-03-29 03:32:51 
- Message: https://ratatoskr.run/linux-fbdev/2011/03/3695992.md

```text
On Mon, Mar 28, 2011 at 09:18:46AM -0700, Jesse Barnes wrote:
> On Thu, 24 Mar 2011 22:50:52 +0200
> Sergey Senozhatsky [ref] wrote:
> 
> > fbcon: Remove unused 'display *p' variable from fb_flashcursor()
> > 
> > Signed-of-by: Sergey Senozhatsky [ref]
> > 
> 
> Looks fine to me, is Paul the lucky owner of fbdev now?
> 
Seems so. I'll roll the patch in with the next batch of fixes.
```