# Re: \[PATCH 1/4\] viafb: kill lcd\_panel\_id

- List: linux-fbdev
- 2 messages, 2 authors
- Page: https://ratatoskr.run/linux-fbdev/2011/03/3689310/t

## Re: \[PATCH 1/4\] viafb: kill lcd\_panel\_id

- From: Chris Ball \<hidden\>
- Date: 2011-03-13 16:10:21 
- Message: https://ratatoskr.run/linux-fbdev/2011/03/3689310.md

```text
Hi Florian,

On Sat, Mar 12 2011, Florian Tobias Schandinat wrote:
> This patch removes all internal uses of another mostly artificial
> value. It does duplicate the information of the maximum resolution and
> it is not flexible as only a few resolutions exist. Hence it is better
> to remove it and clean the mess up.
> No runtime change expected.
>
> Signed-off-by: Florian Tobias Schandinat <FlorianSchandinat@gmx.de>

We're passing viafb_lcd_panel_id at boot-time on OLPC XO-1.5.
Won't this break boot for us, and anyone else who needs to use it?

Thanks,

- Chris.
-- 
Chris Ball   [ref]   <http://printf.net/>
One Laptop Per Child
```

## Re: \[PATCH 1/4\] viafb: kill lcd\_panel\_id

- From: Florian Tobias Schandinat \<FlorianSchandinat@gmx.de\>
- Date: 2011-03-13 17:16:00 
- Message: https://ratatoskr.run/linux-fbdev/2011/03/3689327.md

```text
Hi Chris,

Chris Ball schrieb:
> Hi Florian,
> 
> On Sat, Mar 12 2011, Florian Tobias Schandinat wrote:
>> This patch removes all internal uses of another mostly artificial
>> value. It does duplicate the information of the maximum resolution and
>> it is not flexible as only a few resolutions exist. Hence it is better
>> to remove it and clean the mess up.
>> No runtime change expected.
>>
>> Signed-off-by: Florian Tobias Schandinat <FlorianSchandinat@gmx.de>
> 
> We're passing viafb_lcd_panel_id at boot-time on OLPC XO-1.5.
> Won't this break boot for us, and anyone else who needs to use it?

No need to worry. The external interface is kept for compatibility, only the 
internal uses are replace by panel hres/vres which contain the same information 
but are more generic.
I have not yet tested it on OLPC as I did not have the time to compile a new 
kernel for it, but as it works on my VX900 laptop which also uses the 
viafb_lcd_panel_id setting it should be fine.


Thanks,

Florian Tobias Schandinat

```