# \[PATCH 1/5\] s3fb: maximize virtual vertical size for fast scrolling

- Subsystems: THE REST
- Maintainers: Linus Torvalds
- List: linux-fbdev
- 2 messages, 2 authors
- Page: https://ratatoskr.run/linux-fbdev/2011/03/3684309/t

## \[PATCH 1/5\] s3fb: maximize virtual vertical size for fast scrolling

- From: Ondrej Zary \<hidden\>
- Date: 2011-03-01 19:18:21 
- Message: https://ratatoskr.run/linux-fbdev/2011/03/3684309.md

```text
Maximize virtual vertical framebuffer size during init to allow fast scrolling 
(accelerated by panning).

Signed-off-by: Ondrej Zary <redacted>

--- linux-2.6.38-rc4-/drivers/video/s3fb.c	2011-02-20 19:11:28.000000000 +0100
+++ linux-2.6.38-rc4/drivers/video/s3fb.c	2011-02-20 19:17:04.000000000 +0100
@@ -1060,6 +1060,14 @@ static int __devinit s3_pci_probe(struct
 		goto err_find_mode;
 	}
 
+	/* maximize virtual vertical size for fast scrolling */
+	info->var.yres_virtual = info->fix.smem_len * 8 /
+			(info->var.bits_per_pixel * info->var.xres_virtual);
+	if (info->var.yres_virtual < info->var.yres) {
+		dev_err(info->device, "virtual vertical size smaller than real\n");
+		goto err_find_mode;
+	}
+
 	rc = fb_alloc_cmap(&info->cmap, 256, 0);
 	if (rc < 0) {
 		dev_err(info->device, "cannot allocate colormap\n");

-- 
Ondrej Zary
```

## Re: \[PATCH 1/5\] s3fb: maximize virtual vertical size for fast scrolling

- From: Ondrej Zajicek \<hidden\>
- Date: 2011-03-03 08:59:14 
- Message: https://ratatoskr.run/linux-fbdev/2011/03/3685199.md

```text
On Tue, Mar 01, 2011 at 08:18:08PM +0100, Ondrej Zary wrote:
> Maximize virtual vertical framebuffer size during init to allow fast scrolling 
> (accelerated by panning).
> 
> Signed-off-by: Ondrej Zary <redacted>

Acked-by: Ondrej Zajicek <redacted>

-- 
Elen sila lumenn' omentielvo

Ondrej 'SanTiago' Zajicek (email: santiago@crfreenet.org)
OpenPGP encrypted e-mails preferred (KeyID 0x11DEADC3, wwwkeys.pgp.net)
"To err is human -- to blame it on a computer is even more so."
```