# \[PATCH\] omapfb: Fix linker error in drivers/video/omap/lcd\_2430sdp.c - Subsystems: FRAMEBUFFER LAYER, THE REST - Maintainers: Helge Deller, Linus Torvalds - List: linux-fbdev - 2 messages, 2 authors - Page: https://ratatoskr.run/linux-fbdev/2011/03/13461208/t ## \[PATCH\] omapfb: Fix linker error in drivers/video/omap/lcd\_2430sdp.c - From: Jarkko Nikula \ - Date: 2011-03-01 08:40:37 - Message: https://ratatoskr.run/linux-fbdev/2011/03/13461208.md ```text There is a linker error from lcd_2430sdp.c if CONFIG_TWL4030_CORE is not set. This can be triggered on OMAP2 builds when OMAP3 or OMAP4 are not set. drivers/built-in.o: In function `sdp2430_panel_disable': drivers/video/omap/lcd_2430sdp.c:123: undefined reference to `twl_i2c_write_u8' drivers/video/omap/lcd_2430sdp.c:124: undefined reference to `twl_i2c_write_u8' drivers/built-in.o: In function `sdp2430_panel_enable': drivers/video/omap/lcd_2430sdp.c:110: undefined reference to `twl_i2c_write_u8' drivers/video/omap/lcd_2430sdp.c:112: undefined reference to `twl_i2c_write_u8' Fix this by selecting the TWL4030_CORE for MACH_OMAP_2430SDP when building with CONFIG_FB_OMAP as there is no own Kconfig entry for lcd_2430 and it is compiled always when both MACH_OMAP_2430SDP and FB_OMAP are set. Signed-off-by: Jarkko Nikula --- Quite old issue probably. I don't think any fancier fix is required as this is legacy omapfb code? --- drivers/video/omap/Kconfig | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/drivers/video/omap/Kconfig b/drivers/video/omap/Kconfig index 083c8fe..c981249 100644 --- a/drivers/video/omap/Kconfig +++ b/drivers/video/omap/Kconfig @@ -5,6 +5,7 @@ config FB_OMAP select FB_CFB_FILLRECT select FB_CFB_COPYAREA select FB_CFB_IMAGEBLIT + select TWL4030_CORE if MACH_OMAP_2430SDP help Frame buffer driver for OMAP based boards. -- 1.7.2.3 ``` ## Re: \[PATCH\] omapfb: Fix linker error in - From: Tomi Valkeinen \ - Date: 2011-03-02 07:58:49 - Message: https://ratatoskr.run/linux-fbdev/2011/03/13461206.md ```text On Tue, 2011-03-01 at 02:40 -0600, Jarkko Nikula wrote: > There is a linker error from lcd_2430sdp.c if CONFIG_TWL4030_CORE is not > set. This can be triggered on OMAP2 builds when OMAP3 or OMAP4 are not set. > > drivers/built-in.o: In function `sdp2430_panel_disable': > drivers/video/omap/lcd_2430sdp.c:123: undefined reference to `twl_i2c_write_u8' > drivers/video/omap/lcd_2430sdp.c:124: undefined reference to `twl_i2c_write_u8' > drivers/built-in.o: In function `sdp2430_panel_enable': > drivers/video/omap/lcd_2430sdp.c:110: undefined reference to `twl_i2c_write_u8' > drivers/video/omap/lcd_2430sdp.c:112: undefined reference to `twl_i2c_write_u8' > > Fix this by selecting the TWL4030_CORE for MACH_OMAP_2430SDP when building > with CONFIG_FB_OMAP as there is no own Kconfig entry for lcd_2430 and it is > compiled always when both MACH_OMAP_2430SDP and FB_OMAP are set. Thanks, applied. Tomi ```