[PATCH 2/6] FBDEV: JZ4740: Initialize jzfb->fb earlier

Subsystems: framebuffer layer, the rest

STALE5670d

3 messages, 2 authors, 2011-03-01 · open the first message on its own page

[PATCH 2/6] FBDEV: JZ4740: Initialize jzfb->fb earlier

From: Maurus Cuelenaere <hidden>
Date: 2011-03-01 12:05:57

There's no reason to not do this, and this is needed in the upcoming SLCD
support patches.

Signed-off-by: Maurus Cuelenaere <redacted>
---
 drivers/video/jz4740_fb.c |    3 +--
 1 files changed, 1 insertions(+), 2 deletions(-)
diff --git a/drivers/video/jz4740_fb.c b/drivers/video/jz4740_fb.c
index 65741d0..cea7b7e 100644
--- a/drivers/video/jz4740_fb.c
+++ b/drivers/video/jz4740_fb.c
@@ -654,6 +654,7 @@ static int __devinit jzfb_probe(struct platform_device *pdev)
 	fb->flags = FBINFO_DEFAULT;
 
 	jzfb = fb->par;
+	jzfb->fb = fb;
 	jzfb->pdev = pdev;
 	jzfb->pdata = pdata;
 	jzfb->mem = mem;
@@ -722,8 +723,6 @@ static int __devinit jzfb_probe(struct platform_device *pdev)
 		goto err_free_devmem;
 	}
 
-	jzfb->fb = fb;
-
 	return 0;
 
 err_free_devmem:
-- 
1.7.4

Re: [PATCH 2/6] FBDEV: JZ4740: Initialize jzfb->fb earlier

From: Lars-Peter Clausen <lars@metafoo.de>
Date: 2011-03-01 13:58:13

On 03/01/2011 01:05 PM, Maurus Cuelenaere wrote:
There's no reason to not do this, and this is needed in the upcoming SLCD
support patches.
Is there any specific reason, why this change can't be done in the patch adding
SLCD support?

- Lars
quoted hunk
Signed-off-by: Maurus Cuelenaere <redacted>
---
 drivers/video/jz4740_fb.c |    3 +--
 1 files changed, 1 insertions(+), 2 deletions(-)
diff --git a/drivers/video/jz4740_fb.c b/drivers/video/jz4740_fb.c
index 65741d0..cea7b7e 100644
--- a/drivers/video/jz4740_fb.c
+++ b/drivers/video/jz4740_fb.c
@@ -654,6 +654,7 @@ static int __devinit jzfb_probe(struct platform_device *pdev)
 	fb->flags = FBINFO_DEFAULT;
 
 	jzfb = fb->par;
+	jzfb->fb = fb;
 	jzfb->pdev = pdev;
 	jzfb->pdata = pdata;
 	jzfb->mem = mem;
@@ -722,8 +723,6 @@ static int __devinit jzfb_probe(struct platform_device *pdev)
 		goto err_free_devmem;
 	}
 
-	jzfb->fb = fb;
-
 	return 0;
 
 err_free_devmem:

Re: [PATCH 2/6] FBDEV: JZ4740: Initialize jzfb->fb earlier

From: Maurus Cuelenaere <hidden>
Date: 2011-03-01 17:19:54

Op 01-03-11 14:58, Lars-Peter Clausen schreef:
On 03/01/2011 01:05 PM, Maurus Cuelenaere wrote:
quoted
There's no reason to not do this, and this is needed in the upcoming SLCD
support patches.
Is there any specific reason, why this change can't be done in the patch adding
SLCD support?
I've done this separately because this isn't strictly SLCD-only and thought it
deserved its own commit.
Will merge this.

-- 
Maurus Cuelenaere
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help