# \[PATCH\] video: ffb: fix ffb\_probe error path - Subsystems: FRAMEBUFFER LAYER, THE REST - Maintainers: Helge Deller, Linus Torvalds - List: linux-fbdev - 2 messages, 2 authors - Page: https://ratatoskr.run/linux-fbdev/2011/02/3675046/t ## \[PATCH\] video: ffb: fix ffb\_probe error path - From: Axel Lin \ - Date: 2011-02-08 14:59:03 - Message: https://ratatoskr.run/linux-fbdev/2011/02/3675046.md ```text Current implementation calls of_iounmap for par->fbc twice in error path. In the case of goto out_unmap_dac, we should call of_iounmap for par->dac. Signed-off-by: Axel Lin --- drivers/video/ffb.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/video/ffb.c b/drivers/video/ffb.c index 6739b2a..b5d6a46 100644 --- a/drivers/video/ffb.c +++ b/drivers/video/ffb.c @@ -1011,7 +1011,7 @@ out_dealloc_cmap: fb_dealloc_cmap(&info->cmap); out_unmap_dac: - of_iounmap(&op->resource[2], par->fbc, sizeof(struct ffb_fbc)); + of_iounmap(&op->resource[1], par->dac, sizeof(struct ffb_dac)); out_unmap_fbc: of_iounmap(&op->resource[2], par->fbc, sizeof(struct ffb_fbc)); -- 1.7.1 ``` ## Re: \[PATCH\] video: ffb: fix ffb\_probe error path - From: David Miller \ - Date: 2011-02-08 19:41:14 - Message: https://ratatoskr.run/linux-fbdev/2011/02/3675179.md ```text From: Axel Lin Date: Tue, 08 Feb 2011 22:58:45 +0800 > Current implementation calls of_iounmap for par->fbc twice in error path. > In the case of goto out_unmap_dac, we should call of_iounmap for par->dac. > > Signed-off-by: Axel Lin Good spotting: Acked-by: David S. Miller ```