# \[PATCH 1/2\] s5pc110: add clock gate for MIPI-DSI controller. - Subsystems: ARM PORT, THE REST - Maintainers: Russell King, Linus Torvalds - List: linux-fbdev - 3 messages, 3 authors - Page: https://ratatoskr.run/linux-fbdev/2011/01/8565192/t ## \[PATCH 1/2\] s5pc110: add clock gate for MIPI-DSI controller. - From: Inki Dae \ - Date: 2011-01-05 10:34:50 - Message: https://ratatoskr.run/linux-fbdev/2011/01/8565192.md ```text the clock gate for MIPI-DSI controller is placed at CLK_GATE_IP1[2] so it adds a clock object to clock framework for MIPI-DSI clock gating. Signed-off-by: Inki Dae Signed-off-by: Kyungmin Park --- arch/arm/mach-s5pv210/clock.c | 6 ++++++ 1 files changed, 6 insertions(+), 0 deletions(-) diff --git a/arch/arm/mach-s5pv210/clock.c b/arch/arm/mach-s5pv210/clock.c index dab6ef3..a8d5235 100644 --- a/arch/arm/mach-s5pv210/clock.c +++ b/arch/arm/mach-s5pv210/clock.c @@ -365,6 +365,12 @@ static struct clk init_clocks_disable[] = { .enable = s5pv210_clk_ip1_ctrl, .ctrlbit = (1<<0), }, { + .name = "dsim", + .id = -1, + .parent = &clk_hclk_dsys.clk, + .enable = s5pv210_clk_ip1_ctrl, + .ctrlbit = (1<<2), + }, { .name = "cfcon", .id = 0, .parent = &clk_hclk_psys.clk, -- 1.7.0.4 ``` ## \[PATCH 1/2\] s5pc110: add clock gate for MIPI-DSI controller. - From: Kukjin Kim \ - Date: 2011-03-17 08:23:09 - Message: https://ratatoskr.run/linux-fbdev/2011/03/8571697.md ```text Inki Dae wrote: > > the clock gate for MIPI-DSI controller is placed at CLK_GATE_IP1[2] > so it adds a clock object to clock framework for MIPI-DSI clock gating. > > Signed-off-by: Inki Dae > Signed-off-by: Kyungmin Park > --- > arch/arm/mach-s5pv210/clock.c | 6 ++++++ > 1 files changed, 6 insertions(+), 0 deletions(-) > > diff --git a/arch/arm/mach-s5pv210/clock.c b/arch/arm/mach-s5pv210/clock.c > index dab6ef3..a8d5235 100644 > --- a/arch/arm/mach-s5pv210/clock.c > +++ b/arch/arm/mach-s5pv210/clock.c > @@ -365,6 +365,12 @@ static struct clk init_clocks_disable[] = { > .enable = s5pv210_clk_ip1_ctrl, > .ctrlbit = (1<<0), > }, { > + .name = "dsim", > + .id = -1, > + .parent = &clk_hclk_dsys.clk, > + .enable = s5pv210_clk_ip1_ctrl, > + .ctrlbit = (1<<2), According to coding-style, should be added blank around "<<" like (1 << 2), even though there are wrong things to others. > + }, { > .name = "cfcon", > .id = 0, > .parent = &clk_hclk_psys.clk, > -- > 1.7.0.4 Thanks. Best regards, Kgene. -- Kukjin Kim [ref], Senior Engineer, SW Solution Development Team, Samsung Electronics Co., Ltd. ``` ## \[PATCH 1/2\] s5pc110: add clock gate for MIPI-DSI controller. - From: InKi Dae \ - Date: 2011-03-17 08:28:22 - Message: https://ratatoskr.run/linux-fbdev/2011/03/8571698.md ```text 2011/3/17 Kukjin Kim [ref]: > Inki Dae wrote: >> >> the clock gate for MIPI-DSI controller is placed at CLK_GATE_IP1[2] >> so it adds a clock object to clock framework for MIPI-DSI clock gating. >> >> Signed-off-by: Inki Dae >> Signed-off-by: Kyungmin Park >> --- >>  arch/arm/mach-s5pv210/clock.c |    6 ++++++ >>  1 files changed, 6 insertions(+), 0 deletions(-) >> >> diff --git a/arch/arm/mach-s5pv210/clock.c b/arch/arm/mach-s5pv210/clock.c >> index dab6ef3..a8d5235 100644 >> --- a/arch/arm/mach-s5pv210/clock.c >> +++ b/arch/arm/mach-s5pv210/clock.c >> @@ -365,6 +365,12 @@ static struct clk init_clocks_disable[] = { >>               .enable         = s5pv210_clk_ip1_ctrl, >>               .ctrlbit        = (1<<0), >>       }, { >> +             .name           = "dsim", >> +             .id             = -1, >> +             .parent         = &clk_hclk_dsys.clk, >> +             .enable         = s5pv210_clk_ip1_ctrl, >> +             .ctrlbit        = (1<<2), > > According to coding-style, should be added blank around "<<" like (1 << 2), > even though there are wrong things to others. > ok, I will correct it and give me your comments on my second patch please. thank you. >> +     }, { >>               .name           = "cfcon", >>               .id             = 0, >>               .parent         = &clk_hclk_psys.clk, >> -- >> 1.7.0.4 > > Thanks. > > Best regards, > Kgene. > -- > Kukjin Kim [ref], Senior Engineer, > SW Solution Development Team, Samsung Electronics Co., Ltd. > > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel > ```