# \[PATCH 06/16\] nuc900fb: don't treat NULL clk as an error - Subsystems: FRAMEBUFFER LAYER, THE REST - Maintainers: Helge Deller, Linus Torvalds - List: linux-fbdev - 3 messages, 3 authors - Page: https://ratatoskr.run/linux-fbdev/2011/01/3664367/t ## \[PATCH 06/16\] nuc900fb: don't treat NULL clk as an error - From: Jamie Iles \ - Date: 2011-01-11 12:44:39 - Message: https://ratatoskr.run/linux-fbdev/2011/01/3664367.md ```text clk_get() returns a struct clk cookie to the driver and some platforms may return NULL if they only support a single clock. clk_get() has only failed if it returns a ERR_PTR() encoded pointer. Cc: Wan ZongShun Cc: Signed-off-by: Jamie Iles --- drivers/video/nuc900fb.c | 5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/video/nuc900fb.c b/drivers/video/nuc900fb.c index 81687ed..62498bd 100644 --- a/drivers/video/nuc900fb.c +++ b/drivers/video/nuc900fb.c @@ -15,6 +15,7 @@ */ #include #include +#include #include #include #include @@ -597,9 +598,9 @@ static int __devinit nuc900fb_probe(struct platform_device *pdev) } fbi->clk = clk_get(&pdev->dev, NULL); - if (!fbi->clk || IS_ERR(fbi->clk)) { + if (IS_ERR(fbi->clk)) { printk(KERN_ERR "nuc900-lcd:failed to get lcd clock source\n"); - ret = -ENOENT; + ret = PTR_ERR(fbi->clk); goto release_irq; } -- 1.7.3.4 ``` ## Re: \[PATCH 06/16\] nuc900fb: don't treat NULL clk as an error - From: Wan ZongShun \ - Date: 2011-01-12 01:24:51 - Message: https://ratatoskr.run/linux-fbdev/2011/01/3664637.md ```text 2011/1/11 Jamie Iles [ref]: > clk_get() returns a struct clk cookie to the driver and some platforms > may return NULL if they only support a single clock.  clk_get() has only > failed if it returns a ERR_PTR() encoded pointer. > > Cc: Wan ZongShun > Cc: > Signed-off-by: Jamie Iles > --- >  drivers/video/nuc900fb.c |    5 +++-- >  1 files changed, 3 insertions(+), 2 deletions(-) > > diff --git a/drivers/video/nuc900fb.c b/drivers/video/nuc900fb.c > index 81687ed..62498bd 100644 > --- a/drivers/video/nuc900fb.c > +++ b/drivers/video/nuc900fb.c > @@ -15,6 +15,7 @@ >  */ >  #include >  #include > +#include >  #include >  #include >  #include > @@ -597,9 +598,9 @@ static int __devinit nuc900fb_probe(struct platform_device *pdev) >        } > >        fbi->clk = clk_get(&pdev->dev, NULL); > -       if (!fbi->clk || IS_ERR(fbi->clk)) { > +       if (IS_ERR(fbi->clk)) { >                printk(KERN_ERR "nuc900-lcd:failed to get lcd clock source\n"); > -               ret = -ENOENT; > +               ret = PTR_ERR(fbi->clk); >                goto release_irq; >        } > Hi, Thanks for your patch. Acked-by: Wan ZongShun > -- > 1.7.3.4 > > -- *linux-arm-kernel mailing list mail addr:linux-arm-kernel@lists.infradead.org you can subscribe by: http://lists.infradead.org/mailman/listinfo/linux-arm-kernel * linux-arm-NUC900 mailing list mail addr:NUC900@googlegroups.com main web: https://groups.google.com/group/NUC900 you can subscribe it by sending me mail: mcuos.com@gmail.com ``` ## Re: \[PATCH 06/16\] nuc900fb: don't treat NULL clk as an error - From: Paul Mundt \ - Date: 2011-01-12 06:02:49 - Message: https://ratatoskr.run/linux-fbdev/2011/01/3664684.md ```text On Wed, Jan 12, 2011 at 09:24:47AM +0800, Wan ZongShun wrote: > 2011/1/11 Jamie Iles [ref]: > > clk_get() returns a struct clk cookie to the driver and some platforms > > may return NULL if they only support a single clock. ??clk_get() has only > > failed if it returns a ERR_PTR() encoded pointer. > > > > Cc: Wan ZongShun > > Cc: > > Signed-off-by: Jamie Iles > > Thanks for your patch. > > Acked-by: Wan ZongShun > Applied, thanks. ```