[PATCH 1/3] FB: Add some members for CPU Interface.

Ok, I understood.

I think this issue incompatible with existing users is because userspace API didn't consider cpu mode before.
anyway, I will correct my patch as your comments and send it again.
Perhaps, cpu timing variables would be moved to platform file.

thank you.

------- Original Message -------
Sender : Russell King - ARM Linux[off-list ref] 
Date   : 2010-07-02 16:30 (GMT+09:00)
Title  : Re: [PATCH 1/3] FB: Add some members for CPU Interface.

On Wed, Jun 30, 2010 at 08:02:31AM +0800, Jaya Kumar wrote:

quoted

diff --git a/include/linux/fb.h b/include/linux/fb.h
index 907ace3..73381c3 100644
--- a/include/linux/fb.h
+++ b/include/linux/fb.h

@@ -269,6 +269,12 @@ struct fb_var_screeninfo {
 	__u32 vmode;			/* see FB_VMODE_*		*/
 	__u32 rotate;			/* angle we rotate counter clockwise */
 	__u32 reserved[5];		/* Reserved for future compatibility */
+
+	/* For cpu interface timing. */
+	__u32 cs_setup;
+	__u32 wr_setup;
+	__u32 wr_act;
+	__u32 wr_hold;

This changes the framebuffer userspace API, making it incompatible with
existing users.  What this means is that stuff using the framebuffer API
in userspace has to be upgraded/downgraded in lock-step with this change
- which is not a good idea.
--
To unsubscribe from this list: send the line "unsubscribe linux-fbdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html



ÿôèº{.nÇ+‰·Ÿ®‰­†+%ŠËÿ±éݶ¥Šwÿº{.nÇ+‰·¥Š{±ıöİzÿâ�Ø^n‡r¡ö¦zË�ëh™¨è­Ú&£ûàz¿äz¹Ş—ú+€Ê+zf£¢·hšˆ§~†­†Ûiÿÿï�êÿ‘êçz_è®æj:+v‰¨ş)ߣøm

I think this issue incompatible with existing users is because userspace API didn't consider cpu mode before.
anyway, I will correct my patch as your comments and send it again.
Perhaps, cpu timing variables would be moved to platform file.

I would suggest using sysfs for those extra variables.

thank you.

------- Original Message -------
Sender : Russell King - ARM Linux[off-list ref] 
Date   : 2010-07-02 16:30 (GMT+09:00)
Title  : Re: [PATCH 1/3] FB: Add some members for CPU Interface.

On Wed, Jun 30, 2010 at 08:02:31AM +0800, Jaya Kumar wrote:

quoted

quoted

diff --git a/include/linux/fb.h b/include/linux/fb.h
index 907ace3..73381c3 100644
--- a/include/linux/fb.h
+++ b/include/linux/fb.h

@@ -269,6 +269,12 @@ struct fb_var_screeninfo {
 	__u32 vmode;			/* see FB_VMODE_*		*/
 	__u32 rotate;			/* angle we rotate counter clockwise */
 	__u32 reserved[5];		/* Reserved for future compatibility */
+
+	/* For cpu interface timing. */
+	__u32 cs_setup;
+	__u32 wr_setup;
+	__u32 wr_act;
+	__u32 wr_hold;

This changes the framebuffer userspace API, making it incompatible with
existing users.  What this means is that stuff using the framebuffer API
in userspace has to be upgraded/downgraded in lock-step with this change
- which is not a good idea.
--
To unsubscribe from this list: send the line "unsubscribe linux-fbdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html



N‹§²æìr¸›yúèšØb²X¬¶Ç§vØ^–)Þº{.nÇ+‰·¥Š{±}·^¾)í…æèw*jg¬±¨

¶‰šŽŠÝ¢j/???êäz¹Þ–Šà2ŠÞ™¨è­Ú&¢)ß¡«a¶Úþø
®G«???éh®æj:+v‰¨Šwè†Ù¥