[PATCH] viafb: Add transitive dependencies via gpiolib

FB_VIA now selects GPIOLIB, but that is not available on all
architectures.  Change FB_VIA dependencies to include GPIOLIB
dependencies.

Signed-off-by: Ben Hutchings <redacted>
---
I think the better solution is to make GPIOLIB available for all
platforms, but this will deal with the problem in the short term (i.e.
for 2.6.35).

Ben.

 drivers/video/Kconfig |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/video/Kconfig b/drivers/video/Kconfig
index 3d94a14..bc4534d 100644
--- a/drivers/video/Kconfig
+++ b/drivers/video/Kconfig

@@ -1505,7 +1505,7 @@ config FB_SIS_315
 
 config FB_VIA
        tristate "VIA UniChrome (Pro) and Chrome9 display support"
-       depends on FB && PCI
+       depends on FB && PCI && (ARCH_WANT_OPTIONAL_GPIOLIB || ARCH_REQUIRE_GPIOLIB)
        select FB_CFB_FILLRECT
        select FB_CFB_COPYAREA
        select FB_CFB_IMAGEBLIT

-- 
1.7.1

On Wed, Jul 14, 2010 at 9:30 AM, Ben Hutchings [off-list ref] wrote:

FB_VIA now selects GPIOLIB, but that is not available on all
architectures.  Change FB_VIA dependencies to include GPIOLIB
dependencies.

If you can find a via chipset on anything not x86 I'd be impressed.

Dave.

On Wed, 2010-07-14 at 09:35 +1000, Dave Airlie wrote:

On Wed, Jul 14, 2010 at 9:30 AM, Ben Hutchings [off-list ref] wrote:

quoted

FB_VIA now selects GPIOLIB, but that is not available on all
architectures.  Change FB_VIA dependencies to include GPIOLIB
dependencies.

If you can find a via chipset on anything not x86 I'd be impressed.

If it's really restricted to x86 then that should be added to its
dependencies instead.

Ben.

-- 
Ben Hutchings
Once a job is fouled up, anything done to improve it makes it worse.

Ben Hutchings schrieb:

On Wed, 2010-07-14 at 09:35 +1000, Dave Airlie wrote:

quoted

On Wed, Jul 14, 2010 at 9:30 AM, Ben Hutchings [off-list ref] wrote:

quoted

FB_VIA now selects GPIOLIB, but that is not available on all
architectures.  Change FB_VIA dependencies to include GPIOLIB
dependencies.

If you can find a via chipset on anything not x86 I'd be impressed.

If it's really restricted to x86 then that should be added to its
dependencies instead.

True.
The new VIA ARM tablets aside I don't know anything non-x86 from VIA.
And even if there exists anything non-x86 that includes these IGPs I 
really doubt that the driver is close to supporting it. Hell I do even 
wonder whether it works well on 64 bit but unless there are bug reports 
that's nothing I worry about.


Regards,

Florian Tobias Schandinat

[Been on vacation, behind on a number of things...]

On Wed, 14 Jul 2010 09:35:49 +1000
Dave Airlie [off-list ref] wrote:

quoted

FB_VIA now selects GPIOLIB, but that is not available on all
architectures.  Change FB_VIA dependencies to include GPIOLIB
dependencies.  

If you can find a via chipset on anything not x86 I'd be impressed.

Agreed.  The right fix is almost certainly to just have FB_VIA depend
on X86.

jon