[PATCH] [ARM] omap/board-cm-t35: fix visual artefacts

Subsystems: arm port, omap2+ support, the rest

STALE5919d

2 messages, 1 author, 2010-07-26 · open the first message on its own page

[PATCH] [ARM] omap/board-cm-t35: fix visual artefacts

From: Igor Grinberg <hidden>
Date: 2010-07-12 10:43:49

CM-T35 DVI transmitter sampling the data on the raising edge of the
pixel clock, therefore the data strobe should happen on the falling
edge.

Signed-off-by: Igor Grinberg <redacted>
Signed-off-by: Mike Rapoport <redacted>
---
 arch/arm/mach-omap2/board-cm-t35.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/arch/arm/mach-omap2/board-cm-t35.c b/arch/arm/mach-omap2/board-cm-t35.c
index e679a2c..015ebf8 100644
--- a/arch/arm/mach-omap2/board-cm-t35.c
+++ b/arch/arm/mach-omap2/board-cm-t35.c
@@ -349,6 +349,8 @@ static int cm_t35_panel_enable_dvi(struct omap_dss_device *dssdev)
 		return -EINVAL;
 	}
 
+	dssdev->panel.config |= OMAP_DSS_LCD_IPC | OMAP_DSS_LCD_ONOFF;
+
 	gpio_set_value(dvi_en_gpio, 0);
 	dvi_enabled = 1;
 
-- 
1.7.1

Re: [PATCH] [ARM] omap/board-cm-t35: fix visual artefacts

From: Igor Grinberg <hidden>
Date: 2010-07-26 09:04:33

CM-T35 DVI transmitter sampling the data on the raising edge of the
pixel clock, therefore the data strobe should happen on the falling
edge.

Signed-off-by: Igor Grinberg <redacted>
Signed-off-by: Mike Rapoport <redacted>
  
NAK, this only fixes the pixel clock sampling on the second
call to the platform enable function, because the
dss configuration is done before the first call.

I will send another patch for this.
Sorry for misleading.
quoted hunk
---
 arch/arm/mach-omap2/board-cm-t35.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/arch/arm/mach-omap2/board-cm-t35.c b/arch/arm/mach-omap2/board-cm-t35.c
index e679a2c..015ebf8 100644
--- a/arch/arm/mach-omap2/board-cm-t35.c
+++ b/arch/arm/mach-omap2/board-cm-t35.c
@@ -349,6 +349,8 @@ static int cm_t35_panel_enable_dvi(struct omap_dss_device *dssdev)
 		return -EINVAL;
 	}
 
+	dssdev->panel.config |= OMAP_DSS_LCD_IPC | OMAP_DSS_LCD_ONOFF;
+
 	gpio_set_value(dvi_en_gpio, 0);
 	dvi_enabled = 1;
 
  
-- 
Regards,
Igor.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help