[PATCH] fbcon: deinline large static function get_color()

Subsystems: console subsystem, framebuffer layer, the rest

STALE5967d

2 messages, 2 authors, 2010-06-23 · open the first message on its own page

[PATCH] fbcon: deinline large static function get_color()

From: Denys Vlasenko <hidden>
Date: 2010-06-22 19:06:14 

This function's body is good two screenfuls and it has six callsites.
No apparent reason why it is marked "iniline".

Signed-off-by: Denys Vlasenko <redacted>
---
 drivers/video/console/fbcon.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/video/console/fbcon.c b/drivers/video/console/fbcon.c
index b0a3fa0..24983e4 100644
--- a/drivers/video/console/fbcon.c
+++ b/drivers/video/console/fbcon.c
@@ -286,7 +286,7 @@ static inline int fbcon_is_inactive(struct vc_data *vc, struct fb_info *info)
 		vc->vc_mode != KD_TEXT || ops->graphics);
 }
 
-static inline int get_color(struct vc_data *vc, struct fb_info *info,
+static int get_color(struct vc_data *vc, struct fb_info *info,
 	      u16 c, int is_fg)
 {
 	int depth = fb_get_color_depth(&info->var, &info->fix);
-- 
1.6.2.5

Re: [PATCH] fbcon: deinline large static function get_color()

From: James Simmons <hidden>
Date: 2010-06-23 15:58:46 

This function's body is good two screenfuls and it has six callsites.
No apparent reason why it is marked "iniline".

Signed-off-by: Denys Vlasenko <redacted>
Signed-off-by: James Simmons <redacted>

quoted hunk
---
 drivers/video/console/fbcon.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/video/console/fbcon.c b/drivers/video/console/fbcon.c
index b0a3fa0..24983e4 100644
--- a/drivers/video/console/fbcon.c
+++ b/drivers/video/console/fbcon.c
@@ -286,7 +286,7 @@ static inline int fbcon_is_inactive(struct vc_data *vc, struct fb_info *info)
 		vc->vc_mode != KD_TEXT || ops->graphics);
 }
 
-static inline int get_color(struct vc_data *vc, struct fb_info *info,
+static int get_color(struct vc_data *vc, struct fb_info *info,
 	      u16 c, int is_fg)
 {
 	int depth = fb_get_color_depth(&info->var, &info->fix);
-- 
1.6.2.5

--
To unsubscribe from this list: send the line "unsubscribe linux-fbdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html




    
  

  
    

      

        Keyboard shortcuts
      

      

        
          
hback out one level

          
jnext message in thread

          
kprevious message in thread

          
ldrill in

          
Escclose help / fold thread tree

          
?toggle this help