[PATCH] viafb: Don't accelerate blit of color images

Subsystems: framebuffer layer, the rest

STALE6279d

2 messages, 2 authors, 2009-07-15 · open the first message on its own page

[PATCH] viafb: Don't accelerate blit of color images

From: Daniel Drake <hidden>
Date: 2009-07-15 11:11:27

When the Tux boot logo is enabled, the boot penguin does not get rendered
correctly and under certain circumstances the system will hang.

This appears to be because the accelerated blitting code only supports
mono images at the moment, as suggested by a high bit 8 of the GECMD in
viafb_imageblit().

Fixes http://dev.laptop.org/ticket/9404 and
http://dev.laptop.org/ticket/9322
---
 drivers/video/via/viafbdev.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/video/via/viafbdev.c b/drivers/video/via/viafbdev.c
index 1374312..e91b1be 100644
--- a/drivers/video/via/viafbdev.c
+++ b/drivers/video/via/viafbdev.c
@@ -956,7 +956,7 @@ static void viafb_imageblit(struct fb_info *info,
 	u32 size, bg_col = 0, fg_col = 0, *udata;
 	int i;
 
-	if (!viafb_accel) {
+	if (!viafb_accel || image->depth != 1) {
 		cfb_imageblit(info, image);
 		return;
 	}
-- 
1.6.2.5

Re: [PATCH] viafb: Don't accelerate blit of color images

From: Harald Welte <hidden>
Date: 2009-07-15 20:34:49

On Wed, Jul 15, 2009 at 12:11:27PM +0100, Daniel Drake wrote:
When the Tux boot logo is enabled, the boot penguin does not get rendered
correctly and under certain circumstances the system will hang.

This appears to be because the accelerated blitting code only supports
mono images at the moment, as suggested by a high bit 8 of the GECMD in
viafb_imageblit().
Thanks, I've applied this to my via-viafb branch of linux-2.6-via.git

-- 
- Harald Welte [off-list ref]	    http://linux.via.com.tw/
============================================================================
VIA Free and Open Source Software Liaison
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help