Re: [PATCH] fb: hide cursor in graphics mode

Risto Suominen napisa³(a):

Krzysztof, my patch is basically the same as yours. I already tried
to send it to Xorg mailing list, but did not receive any feedback.

Right. One should set zero the xoffset also (can be non-zero on some cards).

The Xfbdev is incorrectly designed as it uses settings read from one
console to apply them to another console. It breaks if someone uses two 
graphics  cards and the target console is on a different card then a 
current one.

I have to find out what how the problem above affects a HW cursor.

Regards,
Krzysztof

quoted hunk

If virtual resolution is higher than the screen (as in atyfb), and
yoffset
given by the framebuffer driver happens to be non-zero (fbcon changes it
on-
the-fly), Xfbdev places its image starting above the displayed part of
the
framebuffer. This patch makes sure that the whole picture is visible.

Signed-off-by: Risto Suominen >Risto.Suominen@gmail.com>
---
The testing is done on version 1.1.1 and linux kernel version 2.6.18.

--- a/hw/kdrive/fbdev/fbdev.c.org       2006-07-05 21:31:39.000000000
+0300
+++ b/hw/kdrive/fbdev/fbdev.c   2009-01-18 15:42:06.000000000 +0200

@@ -215,6 +215,8 @@ fbdevScreenInitialize (KdScreenInfo *scr

     /* Now get the new screeninfo */
     ioctl (priv->fd, FBIOGET_VSCREENINFO, >priv->var);
+    /* We can get anything into yoffset if fbcon is active */
+    priv->var.yoffset = 0;
     depth = priv->var.bits_per_pixel;
     gray = priv->var.grayscale;

----------------------------------------------------------------------
Promocja w Speak Up. Angielski 50% gratis! 
Liczba miejsc ograniczona. Sprawd¼!>> http://link.interia.pl/f205c



------------------------------------------------------------------------------
Open Source Business Conference (OSBC), March 24-25, 2009, San Francisco, CA
-OSBC tackles the biggest issue in open source: Open Sourcing the Enterprise
-Strategies to boost innovation and cut costs with open source participation
-Receive a $600 discount off the registration fee with the source code: SFAD
http://p.sf.net/sfu/XcvMzF8H