Re: [Linux-fbdev-devel] [PATCH] fb: hide cursor in graphics mode

Krzysztof, my patch is basically the same as yours. I already tried
to send it to Xorg mailing list, but did not receive any feedback.

Risto

If virtual resolution is higher than the screen (as in atyfb), and yoffset
given by the framebuffer driver happens to be non-zero (fbcon changes it on-
the-fly), Xfbdev places its image starting above the displayed part of the
framebuffer. This patch makes sure that the whole picture is visible.

Signed-off-by: Risto Suominen <redacted>
---
The testing is done on version 1.1.1 and linux kernel version 2.6.18.

--- a/hw/kdrive/fbdev/fbdev.c.org       2006-07-05 21:31:39.000000000 +0300
+++ b/hw/kdrive/fbdev/fbdev.c   2009-01-18 15:42:06.000000000 +0200

@@ -215,6 +215,8 @@ fbdevScreenInitialize (KdScreenInfo *scr

     /* Now get the new screeninfo */
     ioctl (priv->fd, FBIOGET_VSCREENINFO, &priv->var);
+    /* We can get anything into yoffset if fbcon is active */
+    priv->var.yoffset = 0;
     depth = priv->var.bits_per_pixel;
     gray = priv->var.grayscale;

Hi Risto,

I ahve checked xorg server 1.1.1 with kernel 2.6.24
 and I cannot reproduce your problem (hw cursor
left in Xfbdev) with two drivers using the hw cursor
(pm2fb and tdfxfb). Tests were done on x86 (amd 
k6-2+ cpu).

Regards,
Krzysztof

----------------------------------------------------------------------
Dzien Kobiet dniem wolnym od pracy? Wypowiedz sie i wygraj nagrode! 
Sprawdz >> http://link.interia.pl/f2076 

I can confirm that the problem exists on x86 (Pentium III) platform,
too, with atyfb (3D RAGE IIC (Mach64 GZ, AGP) [0x475a rev 0x3a]),
kernel 2.6.26, and Xfbdev 1.5.99.902.

An interesting difference:

# setterm -cursor off > /dev/tty7

works on x86, but the opposite:

# setterm -cursor on > /dev/tty7

does not work on Mac (with my patch, so the cursor is off).

The setups, in my tests, on x86 and Mac, are not analogous. On x86,
atyfb is as a module, on Mac, it's linked in. On x86, I used fbset to
select the mode, on Mac, kernel command line has the mode selection.
But all this hardly matters...

Risto

Now I have changed the graphics card on my PC to 3dfx voodoo 3
(tdfxfb), and indeed it made a difference: no cursor. So it begins to
look like the problem only exists on atyfb.

Risto

On Thu, 12 Mar 2009 17:19:13 +0200
Risto Suominen [off-list ref] wrote:

Now I have changed the graphics card on my PC to 3dfx voodoo 3
(tdfxfb), and indeed it made a difference: no cursor. So it begins to
look like the problem only exists on atyfb.

I will look into the atyfb as I have a Rage IIC AGP card now.

I am also very interested into the voodoo3 on PowerPC. Does it work
correctly?

Regards,
Krzysztof


----------------------------------------------------------------------
Zawsze winny jest mezczyzna?! >>> http://link.interia.pl/f2084


------------------------------------------------------------------------------
Apps built with the Adobe(R) Flex(R) framework and Flex Builder(TM) are
powering Web 2.0 with engaging, cross-platform capabilities. Quickly and
easily build your RIAs with Flex Builder, the Eclipse(TM)based development
software that enables intelligent coding and step-through debugging.
Download the free 60 day trial. http://p.sf.net/sfu/www-adobe-com