# Re: \[PATCH\] atyfb\_base.c: fix warning

- From: \<hidden\>
- Date: 2008-07-31 08:30:11 
- List: linux-fbdev
- Page: https://ratatoskr.run/linux-fbdev/2008/07/1132892
- Thread: https://ratatoskr.run/kernel-janitors/2008/07/1132892/t.md

```text
> On Wed, Jul 30, 2008 at 5:03 PM, Alexander Beregalov
> [ref] wrote:
> > From: Alexander Beregalov <redacted>
> >
> > atyfb_base.c: fix warning
> >
> > drivers/video/aty/atyfb_base.c:2663: warning: 'aty_resume_chip' defined
> > but not used
> >
> > Signed-off-by: Alexander Beregalov <redacted>
> > Cc: Ville Syrjala <syrjala@sci.fi>
> > Cc: Antonino A. Daplas <redacted>
> 
> Looks good, should you maybe move the aty_resume_chip() up into the
> existing #if defined(CONFIG_PM) &&... that atyfb_pci_resume() is in?
> Not sure, just a thought.
> 

The same thought has crossed my mind. Kill the forward declaration and move this short function before atyfb_pci_resume().

Regards,
Krzysztof 


----------------------------------------------------------------------
W kosciele tez zdarzaja sie wpadki!
Smieszny filmik >>> http://link.interia.pl/f1e61


-------------------------------------------------------------------------
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK & win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/
```