# Re: \[PATCH\] fbcon: fix wrong vmode bits copied on console switch

- From: Krzysztof Helt \<hidden\>
- Date: 2008-05-28 06:20:16 
- List: linux-fbdev
- Page: https://ratatoskr.run/linux-fbdev/2008/05/13458196
- Thread: https://ratatoskr.run/linux-fbdev/2008/05/13458191/t.md

```text
On Tue, 27 May 2008 20:38:58 -0700
Andrew Morton [ref] wrote:

> On Fri, 23 May 2008 10:09:34 +0200 Krzysztof Helt [ref] wrote:
> 
> > From: Krzysztof Helt <redacted>
> > 
> > The interlaced and double line mode bits should not be
> > copied to new console when the console is switched.
> > Otherwise, the new console may be set to incorrect refresh
> > rate.
> > 
> > Also, the x and y offsets does not need to be copied.
> > 
> > 
> > Signed-off-by: Krzysztof Helt <redacted>

> 
> Do you think this is a needed-in-2.6.26 fix?
> 

It would be nice. 

> And 2.6.25.x?
> 

Rather no.

Geert found that it was introduced in 2.6.15 kernel and nobody complained so this is not a critical must-be fix.

commit e4fc27618b75234b721c4a13d0e0d9d07e75e641
Date:   Tue Nov 8 21:39:09 2005 -0800

    [PATCH] fbcon: Console Rotation - Prepare fbcon for console rotation

Regards,
Krzysztof

----------------------------------------------------------------------
Tanie rozmowy!
Sprawdz >>> http://link.interia.pl/f1e13  


-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
```