# \[PATCH\] fbcon: fix wrong vmode bits copied on console switch

- List: linux-fbdev
- 3 messages, 2 authors
- Page: https://ratatoskr.run/linux-fbdev/2008/05/13458191/t

## \[PATCH\] fbcon: fix wrong vmode bits copied on console switch

- From: Krzysztof Helt \<hidden\>
- Date: 2008-05-23 08:07:57 
- Message: https://ratatoskr.run/linux-fbdev/2008/05/13458191.md

```text
From: Krzysztof Helt <redacted>

The interlaced and double line mode bits should not be
copied to new console when the console is switched.
Otherwise, the new console may be set to incorrect refresh
rate.

Also, the x and y offsets does not need to be copied.


Signed-off-by: Krzysztof Helt <redacted>

diff -urp linux-2.6.25/drivers/video/console/fbcon.c linux-new/drivers/video/console/fbcon.c
--- linux-2.6.25/drivers/video/console/fbcon.c	2008-05-23 10:06:04.144074130 +0200
+++ linux-new/drivers/video/console/fbcon.c	2008-05-23 09:44:50.544333721 +0200
@@ -2274,9 +2274,7 @@ static int fbcon_switch(struct vc_data *
 	 * in fb_set_var()
 	 */
 	info->var.activate = var.activate;
-	var.yoffset = info->var.yoffset;
-	var.xoffset = info->var.xoffset;
-	var.vmode = info->var.vmode;
+	var.vmode |= info->var.vmode & ~FB_VMODE_MASK;
 	fb_set_var(info, &var);
 	ops->var = info->var;
 


----------------------------------------------------------------------
Podbij Dziki Zachod!Gra strategiczna online
Sprawdz >>> http://link.interia.pl/f1dff


-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
```

## Re: \[PATCH\] fbcon: fix wrong vmode bits copied on console switch

- From: Andrew Morton \<akpm@linux-foundation.org\>
- Date: 2008-05-28 03:39:27 
- Message: https://ratatoskr.run/linux-fbdev/2008/05/13458195.md

```text
On Fri, 23 May 2008 10:09:34 +0200 Krzysztof Helt [ref] wrote:

> From: Krzysztof Helt <redacted>
> 
> The interlaced and double line mode bits should not be
> copied to new console when the console is switched.
> Otherwise, the new console may be set to incorrect refresh
> rate.
> 
> Also, the x and y offsets does not need to be copied.
> 
> 
> Signed-off-by: Krzysztof Helt <redacted>
> 
> diff -urp linux-2.6.25/drivers/video/console/fbcon.c linux-new/drivers/video/console/fbcon.c
> --- linux-2.6.25/drivers/video/console/fbcon.c	2008-05-23 10:06:04.144074130 +0200
> +++ linux-new/drivers/video/console/fbcon.c	2008-05-23 09:44:50.544333721 +0200
> @@ -2274,9 +2274,7 @@ static int fbcon_switch(struct vc_data *
>  	 * in fb_set_var()
>  	 */
>  	info->var.activate = var.activate;
> -	var.yoffset = info->var.yoffset;
> -	var.xoffset = info->var.xoffset;
> -	var.vmode = info->var.vmode;
> +	var.vmode |= info->var.vmode & ~FB_VMODE_MASK;
>  	fb_set_var(info, &var);
>  	ops->var = info->var;

Do you think this is a needed-in-2.6.26 fix?

And 2.6.25.x?

Thanks.

-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
```

## Re: \[PATCH\] fbcon: fix wrong vmode bits copied on console switch

- From: Krzysztof Helt \<hidden\>
- Date: 2008-05-28 06:20:16 
- Message: https://ratatoskr.run/linux-fbdev/2008/05/13458196.md

```text
On Tue, 27 May 2008 20:38:58 -0700
Andrew Morton [ref] wrote:

> On Fri, 23 May 2008 10:09:34 +0200 Krzysztof Helt [ref] wrote:
> 
> > From: Krzysztof Helt <redacted>
> > 
> > The interlaced and double line mode bits should not be
> > copied to new console when the console is switched.
> > Otherwise, the new console may be set to incorrect refresh
> > rate.
> > 
> > Also, the x and y offsets does not need to be copied.
> > 
> > 
> > Signed-off-by: Krzysztof Helt <redacted>

> 
> Do you think this is a needed-in-2.6.26 fix?
> 

It would be nice. 

> And 2.6.25.x?
> 

Rather no.

Geert found that it was introduced in 2.6.15 kernel and nobody complained so this is not a critical must-be fix.

commit e4fc27618b75234b721c4a13d0e0d9d07e75e641
Date:   Tue Nov 8 21:39:09 2005 -0800

    [PATCH] fbcon: Console Rotation - Prepare fbcon for console rotation

Regards,
Krzysztof

----------------------------------------------------------------------
Tanie rozmowy!
Sprawdz >>> http://link.interia.pl/f1e13  


-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
```