# Re: \[PATCH 6/9\] viafb: VIA Frame Buffer Device Driver

- From: \<hidden\>
- Date: 2008-05-08 08:00:55 
- List: linux-fbdev
- Page: https://ratatoskr.run/linux-fbdev/2008/05/1097634
- Thread: https://ratatoskr.run/lkml/2008/05/1097106/t.md

```text
Hi Ondrej,

Thanks for your reminding, I will put the configuration file to Documentation/fb next time.
As I know, it should contains some other modes. l check with our engineers later.

BRs,
Joseph Chan 

-----Original Message-----
From: Ondrej Zajicek [mailto:<redacted>] 
Sent: Thursday, May 08, 2008 3:18 PM
To: Joseph Chan
Cc: akpm@linux-foundation.org; geert@linux-m68k.org; <redacted>; <redacted>
Subject: Re: [Linux-fbdev-devel] [PATCH 6/9] viafb: VIA Frame Buffer Device Driver

On Wed, May 07, 2008 at 07:09:42PM +0800, JosephChan@via.com.tw wrote:
> diff -Nur a/drivers/video/via/viafb.modes b/drivers/video/via/viafb.modes
> --- a/drivers/video/via/viafb.modes	1969-12-31 19:00:00.000000000 -0500
> +++ b/drivers/video/via/viafb.modes	2008-04-29 02:51:27.000000000 -0400
> @@ -0,0 +1,870 @@
> +#
> +#
> +#   These data are based on the CRTC parameters in
> +#
> +#       VIA Integration Graphics Chip
> +#       (C) 2004 VIA Technologies Inc.

Configuration file for fbset definitely shouldn't be here between C source files. If it is needed, then it should be somewhere in Documentation/fb .

BTW, Are these modes common VESA modes (DVT, GTF or CVT)  or some other modes. In first case there is probably no reason to include them.

--
Elen sila lumenn' omentielvo

Ondrej 'SanTiago' Zajicek (email: santiago@crfreenet.org) OpenPGP encrypted e-mails preferred (KeyID 0x11DEADC3, wwwkeys.pgp.net) "To err is human -- to blame it on a computer is even more so."


```

## Attachments

- [(unnamed)](https://ratatoskr.run/linux-fbdev/2008/05/1097634/attachment/0) (text/plain, 320 bytes)
- [(unnamed)](https://ratatoskr.run/linux-fbdev/2008/05/1097634/attachment/1) (text/plain, 182 bytes)