# Re: \[PATCH 6/9\] viafb: VIA Frame Buffer Device Driver

- From: \<hidden\>
- Date: 2008-05-08 00:55:05 
- List: linux-fbdev
- Page: https://ratatoskr.run/linux-fbdev/2008/05/1097520
- Thread: https://ratatoskr.run/lkml/2008/05/1097106/t.md

```text
Hi Alan,

Thanks for your reviewing, 
I will push our engineers to check those things your mentioned and suggested.

BRs,
Joseph Chan 

-----Original Message-----
From: Alan Cox [mailto:<redacted>] 
Sent: Wednesday, May 07, 2008 11:21 PM
To: Joseph Chan
Cc: Joseph Chan; akpm@linux-foundation.org; geert@linux-m68k.org; <redacted>; <redacted>
Subject: Re: [Linux-fbdev-devel] [PATCH 6/9] viafb: VIA Frame Buffer Device Driver

> +void delays(int count);
> +void i2cWriteSdaScl(u8 sda, u8 scl);
> +void i2cWriteScl(u8 scl);
> +void i2cReadSdaScl(u8 *pSda, u8 *pScl);

Style is good, code looks clean

One big thing that needs fixing here is the function names. If the driver gets linked into the kernel then the symbols become global - and names like enableGPIO are asking for clashes. The viafb code is fine as it uses viafb_ as the function names. Possibly the helper functions should doo something similar.

We also have a generic i2c layer that might be usable but that is something that could be addressed in the future and isn't really an important detail.

>


```

## Attachments

- [(unnamed)](https://ratatoskr.run/linux-fbdev/2008/05/1097520/attachment/0) (text/plain, 320 bytes)
- [(unnamed)](https://ratatoskr.run/linux-fbdev/2008/05/1097520/attachment/1) (text/plain, 182 bytes)