# Re: \[Linux-fbdev-devel\] \[PATCH 6/9\] viafb: VIA Frame Buffer Device Driver

- From: Alan Cox \<hidden\>
- Date: 2008-05-07 15:31:08 
- List: linux-fbdev
- Page: https://ratatoskr.run/linux-fbdev/2008/05/1097208
- Thread: https://ratatoskr.run/lkml/2008/05/1097106/t.md

```text
> +void delays(int count);
> +void i2cWriteSdaScl(u8 sda, u8 scl);
> +void i2cWriteScl(u8 scl);
> +void i2cReadSdaScl(u8 *pSda, u8 *pScl);

Style is good, code looks clean

One big thing that needs fixing here is the function names. If the driver
gets linked into the kernel then the symbols become global - and names
like enableGPIO are asking for clashes. The viafb code is fine as it uses
viafb_ as the function names. Possibly the helper functions should doo
something similar.

We also have a generic i2c layer that might be usable but that is
something that could be addressed in the future and isn't really an
important detail.

>
```