Re: [PATCH] pm2fb: change option mode to mode_option

Andrew Morton napisa³(a):

On Thu, 14 Feb 2008 22:52:13 +0100
Krzysztof Helt >krzysztof.h1@poczta.fm> wrote:

quoted

From: Krzysztof Helt >krzysztof.h1@wp.pl>

This patch changes the option "mode_option" into "mode".

...
 
-module_param(mode, charp, 0);
-MODULE_PARM_DESC(mode, "Preferred video mode e.g. '648x480-8@60'");
+module_param(mode_option, charp, 0);
+MODULE_PARM_DESC(mode_option, "Initial video mode e.g.

'648x480-8@60'");

quoted

 module_param(lowhsync, bool, 0);
 MODULE_PARM_DESC(lowhsync, "Force horizontal sync low regardless of

mode");

quoted

 module_param(lowvsync, bool, 0);

But it's not backward compatible.  We'll break people's setups.

Not _much_, and we can probably live with it.  But surely it'd be pretty
simple to retain the old option as well?

I'll fix this issue in all patches.

The changed drivers are relatively new. They were added or reworked not longer than 1 year ago (around 2.6.22).

Regards,
Krzysztof



----------------------------------------------------------------------
Masz ostatnia szanse !
Sprawdz >>> http://link.interia.pl/f1d02  


-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/

On Fri, 2008-02-15 at 15:15 +0100, krzysztof.h1@poczta.fm wrote:

Andrew Morton napisał(a):

quoted

On Thu, 14 Feb 2008 22:52:13 +0100
Krzysztof Helt >krzysztof.h1@poczta.fm> wrote:

quoted

From: Krzysztof Helt >krzysztof.h1@wp.pl>

This patch changes the option "mode_option" into "mode".

Thanks very much for your work Krzysztof. I hope that in time most of
the drivers can be made to use the ModeDB framework, so handling of
modes can be done in one place. If I can be of any help, please let me
know. 

Regards,
Alain

-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
_______________________________________________
Linux-fbdev-devel mailing list
Linux-fbdev-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-fbdev-devel