Hi,
Few days ago, a bug was reported that the i810fb uses "mode_option" parameters while other framebuffers uses the "mode" parameter to set initial mode. It was spotted later that some drivers uses "mode_option", some uses "mode" and some does use none.
I want to ask what is a correct way. I can rework at least some of the drivers to a standard way, but I don't know what the standard is.
Kind regards,
Krzysztof
Pogoda na najblizsze dni.
Sprawdz >>> http://link.interia.pl/f1ce1
-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
On Tue, 2008-02-05 at 08:08 +0100, krzysztof.h1@poczta.fm wrote:
Hi,
Few days ago, a bug was reported that the i810fb uses "mode_option" parameters while other framebuffers uses the "mode" parameter to set initial mode. It was spotted later that some drivers uses "mode_option", some uses "mode" and some does use none.
I want to ask what is a correct way. I can rework at least some of the drivers to a standard way, but I don't know what the standard is.
With your permission, I have cc:'ed your question to my original Debian
bug report,
From Documentation/fb/modedb.txt:
---
When a frame buffer device receives a video= option it doesn't know, it
should consider that to be a video mode option. If no frame buffer
device is specified in a video= option, fbmem considers that to be a
global video mode option.
Valid mode specifiers (mode_option argument):
...
From this I believe that 'mode_option' is the standard way, It also
indicates that the parameter name itself is optional, but I am not sure
if there is an overall Linux standard for indicating optional parameter
names.
Kind regards,
Alain
P.S.: Krzysztof, maybe it would be a good idea to update fbmode.txt
too, as there are now many more framebuffer drivers which support video
mode naming.
-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
On Tue, 2008-02-05 at 12:42 +0100, Alain Kalker wrote:
P.S.: Krzysztof, maybe it would be a good idea to update fbmode.txt
too, as there are now many more framebuffer drivers which support video
mode naming.
I have to rephrase that, the situation is much more complicated (sigh).
The only pattern I see is that drivers which support ModeDB (e.g.
i810fb) use the parameter name 'video_mode' which can then be optional,
while others (e.g. cirrusfb) use hardcoded video modes and _require_ the
parameter name to be present, which must then be called 'mode'.
Kind regards,
Alain
-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
On Tue, 2008-02-05 at 13:09 +0100, Alain Kalker wrote:
parameter name 'video_mode'
That should be 'mode_option'.
Need More Coffee ASAP
-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
From: Randy Dunlap <hidden> Date: 2008-02-05 22:03:20
On 05 Feb 2008 08:08:10 +0100 krzysztof.h1@poczta.fm wrote:
Hi,
Few days ago, a bug was reported that the i810fb uses "mode_option" parameters while other framebuffers uses the "mode" parameter to set initial mode. It was spotted later that some drivers uses "mode_option", some uses "mode" and some does use none.
I want to ask what is a correct way. I can rework at least some of the drivers to a standard way, but I don't know what the standard is.
Hi,
Hopefully one of the fbdev driver developers will know for sure.
I would (do) say that "mode_option" is being redundant. Yes, it's
an option, but we don't usually name options (in other parts of the
kernel) with an _option suffix. Sure, the variable could be called
<mode_option>, but the userspace name should just be "mode". IMHO.
Please keep Documentation/fb/modedb.txt updated if you make any
relevant changes.
Thanks.
---
~Randy
-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/