DORMANTno replies REVIEWED: 2 (1M)

2 review trailers.

[PATCH] s3c2410_fb: Fix line length calculation

From: Stefan Schmidt <hidden>
Date: 2008-01-14 14:39:19

Fix line length calculation. var->width is the size of the display in mm. We
like to use the pixel size.

Without this fix, dynamic (fbset) based resolution changes with s3c2410_fb
don't work at all.

Spotted by john cass [off-list ref]

Signed-off-by: Stefan Schmidt <redacted>
Signed-off-by: Harald Welte <redacted>
Acked-by: Ben Dooks <ben-linux@fluff.org>
Acked-by: Arnaud Patard <redacted>

Index: linux-2.6/drivers/video/s3c2410fb.c
===================================================================
--- linux-2.6.orig/drivers/video/s3c2410fb.c
+++ linux-2.6/drivers/video/s3c2410fb.c
@@ -488,7 +488,7 @@
 		break;
 	}
 
-	info->fix.line_length = (var->width * var->bits_per_pixel) / 8;
+	info->fix.line_length = (var->xres_virtual * var->bits_per_pixel) / 8;
 
 	/* activate this new configuration */
 

-------------------------------------------------------------------------
Check out the new SourceForge.net Marketplace.
It's the best place to buy or sell services for
just about anything Open Source.
http://ad.doubleclick.net/clk;164216239;13503038;w?http://sf.net/marketplace
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help