[PATCH 01/33] fbcon: Fix typo and bogus logic in get_default_font

Subsystems: console subsystem, framebuffer layer, the rest

STALE6963d

2 messages, 2 authors, 2007-07-26 · open the first message on its own page

[PATCH 01/33] fbcon: Fix typo and bogus logic in get_default_font

From: "Antonino A. Daplas" <adaplas@gmail.com>
Date: 2007-07-26 12:55:15

Reported in: Bugzilla Bug 8727

Fix typo and bogus logic in get_default_font(). The bug results in
get_default_font() returning a font that may not be displayed properly by a
framebuffer driver.

Signed-off-by: Antonino Daplas <adaplas@gmail.com>
---

 drivers/video/console/fonts.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/video/console/fonts.c b/drivers/video/console/fonts.c
index a6828d0..96979c3 100644
--- a/drivers/video/console/fonts.c
+++ b/drivers/video/console/fonts.c
@@ -133,8 +133,8 @@ #endif
 	if ((yres < 400) == (f->height <= 8))
 	    c += 1000;
 
-	if (!(font_w & (1 << (f->width - 1))) ||
-	    !(font_w & (1 << (f->height - 1))))
+	if ((font_w & (1 << (f->width - 1))) &&
+	    (font_h & (1 << (f->height - 1))))
 	    c += 1000;
 
 	if (c > cc) {


-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems?  Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >>  http://get.splunk.com/

Re: [PATCH 01/33] fbcon: Fix typo and bogus logic in get_default_font

From: Andrew Morton <akpm@linux-foundation.org>
Date: 2007-07-26 17:30:13

It looks like patches 1-6 (at least) are 2.6.23 material, but
I think it'd be better if you were to work out which of these
are for 2.6.23, please?

-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems?  Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >>  http://get.splunk.com/
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help