# Re: \[PATCH 23/24\] matroxfb: Color setting fixes

- From: Antonino Daplas \<adaplas@gmail.com\>
- Date: 2007-06-03 09:59:21 
- List: linux-fbdev
- Page: https://ratatoskr.run/linux-fbdev/2007/06/13457346
- Thread: https://ratatoskr.run/linux-fbdev/2007/06/13457331/t.md

```text
On 6/3/07, Petr Vandrovec [ref] wrote:
> Antonino A. Daplas wrote:
> > - the pseudo_palette is only 16 elements long.
> > - do not write to the pseudo_palette if regno (array index) is more than 15
> >
> > Signed-off-by: Antonino Daplas <adaplas@gmail.com>
>
> NACK.  If you want to remove entry #16, you need to also fix all uses of
> it - matroxfb_crtc2 uses it, matroxfb_accel as well.  Before hardware
> cursor was removed from fbcon it was used by hardware cursor - now it is
> only set, but never used.  Removing entry without removing code to set
> entry #16 memory corruption will occur.
>                                                                 Petr

Okay, I see it now.  Andrew, drop the patch for matroxfb.

Petr,

Do you have plans for the 17th entry?

Tony

-------------------------------------------------------------------------
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/
```
