[PATCH 05/24] ffb: The pseudo_palette is only 16 elements long

Subsystems: framebuffer layer, the rest

STALE6999d

3 messages, 2 authors, 2007-06-05 · open the first message on its own page

[PATCH 05/24] ffb: The pseudo_palette is only 16 elements long

From: "Antonino A. Daplas" <adaplas@gmail.com>
Date: 2007-06-02 10:20:07

The pseudo_palette is only 16 elements long.

Signed-off-by: Antonino Daplas <adaplas@gmail.com>
---

 drivers/video/ffb.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/video/ffb.c b/drivers/video/ffb.c
index 1d4e835..3f6c98f 100644
--- a/drivers/video/ffb.c
+++ b/drivers/video/ffb.c
@@ -656,7 +656,7 @@ static int ffb_setcolreg(unsigned regno,
 {
 	u32 value;
 
-	if (regno >= 256)
+	if (regno >= 16)
 		return 1;
 
 	red >>= 8;
@@ -903,7 +903,7 @@ ffb_init_fix(struct fb_info *info)
 struct all_info {
 	struct fb_info info;
 	struct ffb_par par;
-	u32 pseudo_palette[256];
+	u32 pseudo_palette[16];
 };
 
 static int ffb_init_one(struct of_device *op)



-------------------------------------------------------------------------
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/

Re: [PATCH 05/24] ffb: The pseudo_palette is only 16 elements long

From: David Miller <davem@davemloft.net>
Date: 2007-06-05 20:13:42

From: "Antonino A. Daplas" <adaplas@gmail.com>
Date: Sat, 02 Jun 2007 17:57:36 +0800
The pseudo_palette is only 16 elements long.

Signed-off-by: Antonino Daplas <adaplas@gmail.com>
Antonio, if you don't mind I'll merge the ffb, xvr2500,
and xvr500 pseudo palette fixes in via my Sparc tree.

Thanks for doing this audit!

-------------------------------------------------------------------------
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/

Re: [PATCH 05/24] ffb: The pseudo_palette is only 16 elements long

From: "Antonino A. Daplas" <adaplas@gmail.com>
Date: 2007-06-05 22:46:55

On Tue, 2007-06-05 at 13:13 -0700, David Miller wrote:
From: "Antonino A. Daplas" <adaplas@gmail.com>
Date: Sat, 02 Jun 2007 17:57:36 +0800
quoted
The pseudo_palette is only 16 elements long.

Signed-off-by: Antonino Daplas <adaplas@gmail.com>
Antonio, if you don't mind I'll merge the ffb, xvr2500,
and xvr500 pseudo palette fixes in via my Sparc tree.
No problem.

Tony



-------------------------------------------------------------------------
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help