# \[PATCH\] skeletonfb: improvements

- From: Krzysztof Helt \<hidden\>
- Date: 2007-05-04 17:12:32 
- List: linux-fbdev
- Page: https://ratatoskr.run/linux-fbdev/2007/05/13457171
- Thread: https://ratatoskr.run/linux-fbdev/2007/05/13457171/t.md

```text
From: Krzysztof Helt <redacted>

This patch adds a macro to register PCI ids table and corrects 
type of xxxfb_fix variable to avoid modpost warnings.

Signed-off-by: Krzysztof Helt <redacted>

---


--- linux-2.6.21.orig/drivers/video/skeletonfb.c	2007-05-04 
10:20:25.000000000 +0200
+++ linux-2.6.21/drivers/video/skeletonfb.c	2007-05-04 10:17:
21.000000000 +0200
@@ -84,7 +84,7 @@ struct xxx_par;
  * if we don't use modedb. If we do use modedb see xxxfb_init 
how to use it
  * to get a fb_var_screeninfo. Otherwise define a default var as 
well. 
  */
-static struct fb_fix_screeninfo xxxfb_fix __initdata = {
+static struct fb_fix_screeninfo xxxfb_fix __devinitdata = {
 	.id =		"FB's name", 
 	.type =		FB_TYPE_PACKED_PIXELS,
 	.visual =	FB_VISUAL_PSEUDOCOLOR,
@@ -705,7 +705,7 @@ static int __devinit xxxfb_probe(struct 
     info->screen_base = framebuffer_virtual_memory;
     info->fbops = &xxxfb_ops;
     info->fix = xxxfb_fix; /* this will be the only time 
xxxfb_fix will be
-			    * used, so mark it as __initdata
+			    * used, so mark it as __devinitdata
 			    */
     info->pseudo_palette = pseudo_palette; /* The pseudopalette 
is an
 					    * 16-member array
@@ -900,6 +900,8 @@ static struct pci_driver xxxfb_driver = 
 	.resume =       xxxfb_resume,  /* optional but recommended */
 };
 
+MODULE_DEVICE_TABLE(pci, xxxfb_id_table);
+
 int __init xxxfb_init(void)
 {
 	/*


----------------------------------------------------
Już niedługo pierwsza komunia! Zrób naprawdę niezapomniany prezent:
Pięknie wydany i zilustrowany album do uzupełnienia przez dziecko
będzie na całe życie kroniką Pierwszej Komunii Świętej - Zobacz:
http://klik.wp.pl/?adr=http%3A%2F%2Fadv.reklama.wp.pl%2Fas%2Fkom.html&sid=1125
```

## Attachments

- [skeletonfb-improvements.diff](https://ratatoskr.run/linux-fbdev/2007/05/13457171/attachment/0) (application/octet-stream, 1194 bytes)
- [(unnamed)](https://ratatoskr.run/linux-fbdev/2007/05/13457171/attachment/1) (text/plain, 286 bytes)
- [(unnamed)](https://ratatoskr.run/linux-fbdev/2007/05/13457171/attachment/2) (text/plain, 182 bytes)
