[PATCH 1/3] sstfb: fix pixclock setting on Voodoo 1/2 cards

Subsystems: framebuffer layer, the rest

STALE7162d

3 messages, 2 authors, 2007-03-11 · open the first message on its own page

[PATCH 1/3] sstfb: fix pixclock setting on Voodoo 1/2 cards

From: "Antonino A. Daplas" <adaplas@gmail.com>
Date: 2007-03-11 12:10:39

From: Ondrej Zajicek <redacted>

Pixclock setting in sstfb didn't work with my Voodoo 2 card
with ICS 5342 DAC (this DAC requires two consecutive writes
to one of its registers to program pixclock - maybe first
write merged with second).

This patch fixes bug with pixclock setting. It is against
2.6.21-rc1 .

Signed-off-by: Ondrej Zajicek <redacted>
Signed-off-by: Antonino Daplas <adaplas@gmail.com>
---

 drivers/video/sstfb.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/drivers/video/sstfb.c b/drivers/video/sstfb.c
index 59cd1e7..62fa550 100644
--- a/drivers/video/sstfb.c
+++ b/drivers/video/sstfb.c
@@ -257,6 +257,7 @@ static void __sst_dac_write(u8 __iomem *
 	r_dprintk("sst_dac_write(%#x, %#x)\n", reg, val);
 	reg &= 0x07;
 	__sst_write(vbase, DAC_DATA,(((u32)reg << 8)) | (u32)val);
+	__sst_wait_idle(vbase);
 }
 
 /* indexed access to ti/att dacs */



-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys-and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV

Re: [PATCH 1/3] sstfb: fix pixclock setting on Voodoo 1/2 cards

From: Andrew Morton <akpm@linux-foundation.org>
Date: 2007-03-11 12:36:48

These three patches look 2.6.21ish to me?

-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys-and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV

Re: [PATCH 1/3] sstfb: fix pixclock setting on Voodoo 1/2 cards

From: "Antonino A. Daplas" <adaplas@gmail.com>
Date: 2007-03-11 13:01:36

On Sun, 2007-03-11 at 04:36 -0800, Andrew Morton wrote:
These three patches look 2.6.21ish to me?
They are safe for 2.6.21.

Tony


-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys-and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help