Hello,
we would like to use your drivers in our software. While debugging we
found a bug in calculating the ring_space.
If there is less then RING_MIN_FREE available in the ring buffer,
dinfo->ring_space is set to a big value forcing wait_ring to return.
We have attached a possible solution to solve this bug.
<<intelfbhw.c>>
Best regards
Juergen Orczykowski
Siemens AG
Automation and Drives, A&D MC RD 37
Tel. : +49 (9131) 98-3599
Fax : +49 (9131) 98-2360
mailto:juergen.orczykowski@siemens.com
Siemens Aktiengesellschaft: Chairman of the Supervisory Board: Heinrich
v. Pierer;
Managing Board: Klaus Kleinfeld, Chairman, President and Chief Executive
Officer;
Johannes Feldmayer, Joe Kaeser, Rudi Lamprecht, Eduardo Montes, Juergen
Radomski,
Erich R. Reinhardt, Hermann Requardt, Uriel J. Sharef, Klaus Wucherer
Registered offices: Berlin and Munich
Commercial registries: Berlin Charlottenburg, HRB 12300, Munich, HRB
6684
WEEE Reg. No. DE 23691322
From: "Antonino A. Daplas" <adaplas@gmail.com> Date: 2007-02-22 08:59:47
On Thu, 2007-02-22 at 09:14 +0100, Orczykowski, Juergen wrote:
Hello,
we would like to use your drivers in our software. While debugging we
found a bug in calculating the ring_space.
If there is less then RING_MIN_FREE available in the ring buffer,
dinfo->ring_space is set to a big value forcing wait_ring to return.
We have attached a possible solution to solve this bug.
Okay, I see the problem too, and your solution looks sane. I'll make a
patch out of this, and send it to the intelfb maintainer.
Thanks.
Tony
-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys-and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
From: "Antonino A. Daplas" <adaplas@gmail.com> Date: 2007-02-22 09:25:11
On Thu, 2007-02-22 at 09:14 +0100, Orczykowski, Juergen wrote:
Hello,
we would like to use your drivers in our software. While debugging we
found a bug in calculating the ring_space.
If there is less then RING_MIN_FREE available in the ring buffer,
dinfo->ring_space is set to a big value forcing wait_ring to return.
We have attached a possible solution to solve this bug.
Dave,
I created a patch based on the source. I don't have the hardware so do
you want to look at this?
Tony
Hi Tony,
Sorry, but in the diff, we miss our (similar) change in the function refresh_ring.
Best regards
Juergen Orczykowski
Siemens AG
Automation and Drives, A&D MC RD 37
Tel. : +49 (9131) 98-3599
Fax. : +49 (9131) 98-2360
mailto:juergen.orczykowski@siemens.com
Siemens Aktiengesellschaft: Chairman of the Supervisory Board: Heinrich v. Pierer;
Managing Board: Klaus Kleinfeld, Chairman, President and Chief Executive Officer;
Johannes Feldmayer, Joe Kaeser, Rudi Lamprecht, Eduardo Montes, Juergen Radomski,
Erich R. Reinhardt, Hermann Requardt, Uriel J. Sharef, Klaus Wucherer
Registered offices: Berlin and Munich
Commercial registries: Berlin Charlottenburg, HRB 12300, Munich, HRB 6684
WEEE Reg. No. DE 23691322
-----Ursprüngliche Nachricht-----
Von: Antonino A. Daplas [mailto:adaplas@gmail.com]
Gesendet: Donnerstag, 22. Februar 2007 10:28
An: linux-fbdev-devel@lists.sourceforge.net
Cc: Dave Airlie; Orczykowski, Juergen
Betreff: Re: [Linux-fbdev-devel] bug in intelfbhw.c
On Thu, 2007-02-22 at 09:14 +0100, Orczykowski, Juergen wrote:
Hello,
we would like to use your drivers in our software. While debugging we
found a bug in calculating the ring_space.
If there is less then RING_MIN_FREE available in the ring buffer,
dinfo->ring_space is set to a big value forcing wait_ring to return.
We have attached a possible solution to solve this bug.
Dave,
I created a patch based on the source. I don't have the hardware so do
you want to look at this?
Tony
-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys-and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
Sorry I just noticed this it looks fine to me the accel code isn't the
best in any case...
Tony can you push it via Andrew? my git tree needs some cleanup...
Signed-off-by: David Airlie <redacted>
-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys-and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
From: "Antonino A. Daplas" <adaplas@gmail.com> Date: 2007-02-23 00:54:30
On Fri, 2007-02-23 at 11:43 +1100, Dave Airlie wrote:
quoted
Dave, here's an updated patch.
Sorry I just noticed this it looks fine to me the accel code isn't the
best in any case...
Tony can you push it via Andrew? my git tree needs some cleanup...
Signed-off-by: David Airlie <redacted>
Okay.
Tony
-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys-and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV