# Re: \[Cbe-oss-dev\] \[PATCH 6/6\] Cell: Draw SPE helper penguin logos

- From: Arnd Bergmann \<arnd@arndb.de\>
- Date: 2007-01-31 01:15:57 
- List: linux-fbdev
- Page: https://ratatoskr.run/linux-fbdev/2007/01/13456829
- Thread: https://ratatoskr.run/linux-fbdev/2007/01/13456821/t.md

```text
On Tuesday 30 January 2007 19:02, Geert Uytterhoeven wrote:
> +#ifdef CONFIG_LOGO
> +       if (ret > 0) {
> +               extern const struct linux_logo logo_spe_clut224;
> +               fb_append_extra_logo(&logo_spe_clut224, ret);
> +       }
> +#endif

You should not have the #ifdef nor the extern declaration in here.
A better way to do it would be to have in include/linux/linux_logo.h
(or similar):

extern const struct linux_logo logo_spe_clut224;
#ifdef CONFIG_LOGO
extern void fb_append_extra_logo(const struct linux_logo *logo, int n);
#else
static inline void fb_append_extra_logo(const struct linux_logo *logo, int n)
{
}
#endif

	Arnd <><

-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys - and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
```
