From: James Simmons <hidden> Date: 2006-11-21 15:05:07
Can you post the framebufer driver to the framebuffer list. We like to do
peer review. Thank you :-)
On Tue, 21 Nov 2006, Vladimir wrote:
2006/11/20, Tony Lindgren [off-list ref]:
quoted
* Pavel Machek [off-list ref] [061118 18:16]:
quoted
From: Vladimir Ananiev <redacted>
Framebuffer support for Siemens SX1; this is second big patch. (Third
one will be mixer/sound support). Support is simple / pretty minimal,
but seems to work okay (and is somehow important for a cell phone :-).
Pushed to linux-omap. I guess you're planning to send the missing
Kconfig + Makefile patch for this?
Also, it would be better to use omap_mcbsp_xmit_word() or
omap_mcsbsp_spi_master_xmit_word_poll() instead of OMAP_MCBSP_WRITE as
it does not do any checking that it worked. The aic23 and tsc2101
audio in linux-omap tree in general has the same problem.
Regards,
Tony
Hmm. McBSP3 in SX1 is used in "GPIO mode". The only line used is CLKX,
so I think OMAP_MCBSP_WRITE would be enough. Am I wrong ?
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys - and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
From: Komal Shah <hidden> Date: 2006-11-21 15:34:59
On 11/21/06, James Simmons [off-list ref] wrote:
Can you post the framebufer driver to the framebuffer list. We like to do
peer review. Thank you :-)
On Tue, 21 Nov 2006, Vladimir wrote:
quoted
2006/11/20, Tony Lindgren [off-list ref]:
quoted
* Pavel Machek [off-list ref] [061118 18:16]:
quoted
From: Vladimir Ananiev <redacted>
Framebuffer support for Siemens SX1; this is second big patch. (Third
one will be mixer/sound support). Support is simple / pretty minimal,
but seems to work okay (and is somehow important for a cell phone :-).
Pushed to linux-omap. I guess you're planning to send the missing
Kconfig + Makefile patch for this?
Also, it would be better to use omap_mcbsp_xmit_word() or
omap_mcsbsp_spi_master_xmit_word_poll() instead of OMAP_MCBSP_WRITE as
it does not do any checking that it worked. The aic23 and tsc2101
audio in linux-omap tree in general has the same problem.
Regards,
Tony
Hmm. McBSP3 in SX1 is used in "GPIO mode". The only line used is CLKX,
so I think OMAP_MCBSP_WRITE would be enough. Am I wrong ?
-
Again, framebuffer support patch is based on the omap framebuffer
driver, which is not yet submitted to upstream/fbdevel list. sx1
framebuffer support just fill up the hooks required by -omap fb driver
framework.
--
---Komal Shah
http://komalshah.blogspot.com
From: Tony Lindgren <tony@atomide.com> Date: 2006-11-21 16:49:39
Hi,
* Komal Shah [off-list ref] [061121 15:35]:
On 11/21/06, James Simmons [off-list ref] wrote:
quoted
Can you post the framebufer driver to the framebuffer list. We like to do
peer review. Thank you :-)
It would be nice to get the framebuffer integrated. I think it would be
best if Imre submitted the patches as it's mostly his work.
Imre, do you have time to send the patches to framebuffer list? If not,
I can send them.
quoted
On Tue, 21 Nov 2006, Vladimir wrote:
quoted
2006/11/20, Tony Lindgren [off-list ref]:
quoted
* Pavel Machek [off-list ref] [061118 18:16]:
quoted
From: Vladimir Ananiev <redacted>
Framebuffer support for Siemens SX1; this is second big patch. (Third
one will be mixer/sound support). Support is simple / pretty minimal,
but seems to work okay (and is somehow important for a cell phone
:-).
quoted
quoted
Pushed to linux-omap. I guess you're planning to send the missing
Kconfig + Makefile patch for this?
Also, it would be better to use omap_mcbsp_xmit_word() or
omap_mcsbsp_spi_master_xmit_word_poll() instead of OMAP_MCBSP_WRITE as
it does not do any checking that it worked. The aic23 and tsc2101
audio in linux-omap tree in general has the same problem.
Regards,
Tony
Hmm. McBSP3 in SX1 is used in "GPIO mode". The only line used is CLKX,
so I think OMAP_MCBSP_WRITE would be enough. Am I wrong ?
-
Again, framebuffer support patch is based on the omap framebuffer
driver, which is not yet submitted to upstream/fbdevel list. sx1
framebuffer support just fill up the hooks required by -omap fb driver
framework.
Yes, but the framebuffer code is in pretty much ready to be sent
upstream :)
Regards,
Tony
From: Imre Deák <hidden> Date: 2006-11-22 12:12:14
Hi Tony and all,
On Tue, Nov 21, 2006 at 04:47:25PM +0000, Tony Lindgren wrote:
Hi,
* Komal Shah [off-list ref] [061121 15:35]:
quoted
On 11/21/06, James Simmons [off-list ref] wrote:
quoted
Can you post the framebufer driver to the framebuffer list. We like to do
peer review. Thank you :-)
It would be nice to get the framebuffer integrated. I think it would be
best if Imre submitted the patches as it's mostly his work.
Imre, do you have time to send the patches to framebuffer list? If not,
I can send them.
Yes, I'm going to post it this week.
--Imre
quoted
quoted
On Tue, 21 Nov 2006, Vladimir wrote:
quoted
2006/11/20, Tony Lindgren [off-list ref]:
quoted
* Pavel Machek [off-list ref] [061118 18:16]:
quoted
From: Vladimir Ananiev <redacted>
Framebuffer support for Siemens SX1; this is second big patch. (Third
one will be mixer/sound support). Support is simple / pretty minimal,
but seems to work okay (and is somehow important for a cell phone
:-).
quoted
quoted
Pushed to linux-omap. I guess you're planning to send the missing
Kconfig + Makefile patch for this?
Also, it would be better to use omap_mcbsp_xmit_word() or
omap_mcsbsp_spi_master_xmit_word_poll() instead of OMAP_MCBSP_WRITE as
it does not do any checking that it worked. The aic23 and tsc2101
audio in linux-omap tree in general has the same problem.
Regards,
Tony
Hmm. McBSP3 in SX1 is used in "GPIO mode". The only line used is CLKX,
so I think OMAP_MCBSP_WRITE would be enough. Am I wrong ?
-
Again, framebuffer support patch is based on the omap framebuffer
driver, which is not yet submitted to upstream/fbdevel list. sx1
framebuffer support just fill up the hooks required by -omap fb driver
framework.
Yes, but the framebuffer code is in pretty much ready to be sent
upstream :)
Regards,
Tony