# \[PATCH 2.6.18-rc2\] intelfb: fix vblank\_end calculation

- From: Dennis Munsie \<hidden\>
- Date: 2006-07-20 16:23:13 
- List: linux-fbdev
- Page: https://ratatoskr.run/linux-fbdev/2006/07/13456466
- Thread: https://ratatoskr.run/linux-fbdev/2006/07/13456466/t.md

```text
From: Dennis Munsie <redacted>

Removes bad vblank_end calculation in favor of the correct one on the line 
above.  This makes the vblank_end now include both the upper and lower margin,
and the vsync.  Before, the upper margin was not being included which caused 
problems with DVI monitors.  This patch shouldn't affect analog monitors,
but vertical adjustments may need to be made.

This now brings the vblank_end value to be consistent with what the BIOS is
setting when using VBE calls.

Signed-off-by: Dennis Munsie <redacted>

---

 drivers/video/intelfb/intelfbhw.c |    1 -
 1 file changed, 1 deletion(-)

diff -Naurp -X linux-2.6.18-rc2-patched/Documentation/dontdiff linux-2.6.18-rc2-patched/drivers/video/intelfb/intelfbhw.c linux-2.6.18-rc2-debugging/drivers/video/intelfb/intelfbhw.c
--- linux-2.6.18-rc2-patched/drivers/video/intelfb/intelfbhw.c	2006-07-18 05:15:21.000000000 -0500
+++ linux-2.6.18-rc2-debugging/drivers/video/intelfb/intelfbhw.c	2006-07-20 03:39:52.000000000 -0500
@@ -1140,7 +1140,6 @@ intelfbhw_mode_to_hw(struct intelfb_info
 	vtotal = vsync_end + var->upper_margin;
 	vblank_start = vactive;
 	vblank_end = vtotal;
-	vblank_end = vsync_end + 1;
 
 	DBG_MSG("V: act %d, ss %d, se %d, tot %d bs %d, be %d\n",
 		vactive, vsync_start, vsync_end, vtotal, vblank_start,

-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys -- and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
```
