[PATCH] Fix maxine compilation error

I have no idea if the patch below is correct.  Are fb_get_fix/fb_get_var
still needed?  Is there any information about converting fb drivers to
the 2.6 api?


[PATCH] Fix maxine compilation error

Fix the following compilation error:

  CC      drivers/video/maxinefb.o
drivers/video/maxinefb.c:58: warning: initializer-string for array of chars is too long
drivers/video/maxinefb.c:58: warning: (near initialization for ‘maxinefb_fix.id’)
drivers/video/maxinefb.c:110: error: unknown field ‘fb_get_fix’ specified in initializer
drivers/video/maxinefb.c:110: error: ‘gen_get_fix’ undeclared here (not in a function)
drivers/video/maxinefb.c:111: error: unknown field ‘fb_get_var’ specified in initializer
drivers/video/maxinefb.c:111: error: ‘gen_get_var’ undeclared here (not in a function)
make[2]: *** [drivers/video/maxinefb.o] Error 1

Signed-off-by: Martin Michlmayr <redacted>

--- drivers/video/maxinefb.c~	2006-05-09 20:50:36.000000000 +0000
+++ drivers/video/maxinefb.c	2006-05-09 20:57:27.000000000 +0000

@@ -55,7 +55,7 @@
 };
 
 static struct fb_fix_screeninfo maxinefb_fix = {
-	.id =		"Maxine onboard graphics 1024x768x8",
+	.id =		"Maxine",
 	.smem_len =	(1024*768),
 	.type =		FB_TYPE_PACKED_PIXELS,
 	.visual =	FB_VISUAL_PSEUDOCOLOR,

@@ -107,8 +107,6 @@
 
 static struct fb_ops maxinefb_ops = {
 	.owner		= THIS_MODULE,
-	.fb_get_fix	= gen_get_fix,
-	.fb_get_var	= gen_get_var,
 	.fb_setcolreg	= maxinefb_setcolreg,
 	.fb_fillrect	= cfb_fillrect,
 	.fb_copyarea	= cfb_copyarea,

-- 
Martin Michlmayr
http://www.cyrius.com/


-------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid0709&bid&3057&dat1642

Martin Michlmayr wrote:

I have no idea if the patch below is correct.

It's correct.

Are fb_get_fix/fb_get_var
still needed?

With 2.6, not anymore.

 Is there any information about converting fb drivers to
the 2.6 api?

None in terms of conversion.  But skeletonfb.c in the video
directory might help.

Tony


-------------------------------------------------------
All the advantages of Linux Managed Hosting--Without the Cost and Risk!
Fully trained technicians. The highest number of Red Hat certifications in
the hosting industry. Fanatical Support. Click to learn more
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=107521&bid=248729&dat=121642