3 messages, 2 authors, 2006-03-23 · open the first message on its own page
From: Mardy <hidden>
Date: 2006-03-23 11:29:51
Hi, please consider applying the attached patch. It adds acceleration
support in w100fb.c (i.e. ATI Imageons) for the copyarea and fillrect
operations.
Since this is my first submission, please let me know if there's
something else that should be done.
Comments are welcome.
--
Saluti,
Mardy
http://interlingua.altervista.org
From: Geert Uytterhoeven <geert@linux-m68k.org>
Date: 2006-03-23 12:23:40
On Thu, 23 Mar 2006, Mardy wrote:
Hi, please consider applying the attached patch. It adds acceleration support in w100fb.c (i.e. ATI Imageons) for the copyarea and fillrect operations. Since this is my first submission, please let me know if there's something else that should be done.
A Signed-Off-By line?
+struct dp_gui_master_cntl_t {
+ unsigned long gmc_src_pitch_offset_cntl : 1; ^^^^^^^^^^^^^
I'm not sure it's a good idea to use `long' here, since the size of long is
different for 32 and 64 bit platforms.
OTOH, in my copy of C99, I didn't immediately find out whether using `long' or
`int' here has any visible effect at all.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
-------------------------------------------------------
This SF.Net email is sponsored by xPML, a groundbreaking scripting language
that extends applications into web and mobile media. Attend the live webcast
and join the prime developer group breaking into this new coding territory!
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=110944&bid=241720&dat=121642
From: Mardy <hidden>
Date: 2006-03-23 13:23:19
Le die Thu, Mar 23, 2006 at 01:23:33PM +0100, Geert Uytterhoeven ha scribite:
quoted
Since this is my first submission, please let me know if there's something else that should be done.A Signed-Off-By line?
Maybe ;-) [...bitfields type...]
OTOH, in my copy of C99, I didn't immediately find out whether using `long' or `int' here has any visible effect at all.
I think it shouldn't make any difference, but for consistency I'll
submit a patch that changes all those "unsigned long" to "u32".
--
Saluti,
Mardy
http://interlingua.altervista.org
___________________________________
Yahoo! Messenger with Voice: chiama da PC a telefono a tariffe esclusive
http://it.messenger.yahoo.com
-------------------------------------------------------
This SF.Net email is sponsored by xPML, a groundbreaking scripting language
that extends applications into web and mobile media. Attend the live webcast
and join the prime developer group breaking into this new coding territory!
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=110944&bid=241720&dat=121642