# Re: \[PATCH\] aty: remove unnecessary CONFIG\_PCI

- From: Geert Uytterhoeven \<geert@linux-m68k.org\>
- Date: 2006-01-10 20:27:33 
- List: linux-fbdev
- Page: https://ratatoskr.run/linux-fbdev/2006/01/13455898
- Thread: https://ratatoskr.run/linux-fbdev/2006/01/13455898/t.md

```text
On Tue, 10 Jan 2006, Linux Kernel Mailing List wrote:
> tree 2567482d480da5d320cc7af065f03716e41dbbd6
> parent 2b4f2f4b0132afa9f441171285cca354377bf5d0
> author Richard Knutsson [ref] Tue, 10 Jan 2006 12:52:55 -0800
> committer Linus Torvalds [ref] Wed, 11 Jan 2006 00:01:42 -0800
> 
> [PATCH] aty: remove unnecessary CONFIG_PCI
> 
> Signed-off-by: Richard Knutsson <redacted>
> Cc: "Antonino A. Daplas" <redacted>
> Signed-off-by: Andrew Morton <redacted>
> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
> 
>  drivers/video/aty/atyfb_base.c |    4 ----
>  1 files changed, 4 deletions(-)
> 
> diff --git a/drivers/video/aty/atyfb_base.c b/drivers/video/aty/atyfb_base.c
> index 3fefdb0..d8195f7 100644
> --- a/drivers/video/aty/atyfb_base.c
> +++ b/drivers/video/aty/atyfb_base.c
> @@ -3692,9 +3692,7 @@ static int __init atyfb_init(void)
>      atyfb_setup(option);
>  #endif
>  
> -#ifdef CONFIG_PCI
>      pci_register_driver(&atyfb_driver);
> -#endif
>  #ifdef CONFIG_ATARI
>      atyfb_atari_probe();
>  #endif
> @@ -3703,9 +3701,7 @@ static int __init atyfb_init(void)
>  
>  static void __exit atyfb_exit(void)
>  {
> -#ifdef CONFIG_PCI
>  	pci_unregister_driver(&atyfb_driver);
> -#endif
>  }

Have you compile-tested this? Since atyfb_driver is not defined if CONFIG_PCI
is not set and pci_register_driver() is not a macro but an inline function (so
the compiler will see the reference to atyfb_driver), I'm afraid it will break
the non-CONFIG_PCI build.

[Disclaimer: I'm not in a position to compile-test it myself right now]

Gr{oetje,eeting}s,

						Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
							    -- Linus Torvalds


-------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc. Do you grep through log files
for problems?  Stop!  Download the new AJAX search engine that makes
searching your log files as easy as surfing the  web.  DOWNLOAD SPLUNK!
http://ads.osdn.com/?ad_id=7637&alloc_id=16865&op=click
```
