From: Jon Smirl <hidden> Date: 2005-02-24 20:39:58
I'm starting to get too many patches hanging around. Is there any
reason this one can't be pushed up stream? My next target would be the
sysfs patch.
--
Jon Smirl
jonsmirl@gmail.com
diff -Nru a/drivers/video/Kconfig b/drivers/video/Kconfig
fbsysfs.o modedb.o softcursor.o
+obj-$(CONFIG_FB) += fb.o
+fb-y := fbmem.o fbmon.o fbcmap.o
fbsysfs.o modedb.o softcursor.o
# Only include macmodes.o if we have FB support and are PPC
-ifeq ($(CONFIG_FB),y)
-obj-$(CONFIG_PPC) += macmodes.o
+ifneq ($(CONFIG_FB),n)
+fb-$(CONFIG_PPC) += macmodes.o
endif
+fb-objs := $(fb-y)
# Hardware specific drivers go first
obj-$(CONFIG_FB_RETINAZ3) += retz3fb.o
diff -Nru a/drivers/video/fbmem.c b/drivers/video/fbmem.c
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users.
Discover which products truly live up to the hype. Start reading now.
http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click
From: Antonino A. Daplas <hidden> Date: 2005-02-24 23:06:13
On Friday 25 February 2005 04:39, Jon Smirl wrote:
I'm starting to get too many patches hanging around. Is there any
reason this one can't be pushed up stream? My next target would be the
sysfs patch.
Wait until 2.6.11 comes out. Linus will not accept, and Andrew will not
push patches unless they're bug fixes.
Tony
-------------------------------------------------------
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users.
Discover which products truly live up to the hype. Start reading now.
http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click
From: Jon Smirl <hidden> Date: 2005-02-24 23:16:38
Can I assume then that it is acceptable and all we are waiting on is 2.6.11?
On Fri, 25 Feb 2005 07:04:49 +0800, Antonino A. Daplas
[off-list ref] wrote:
On Friday 25 February 2005 04:39, Jon Smirl wrote:
quoted
I'm starting to get too many patches hanging around. Is there any
reason this one can't be pushed up stream? My next target would be the
sysfs patch.
Wait until 2.6.11 comes out. Linus will not accept, and Andrew will not
push patches unless they're bug fixes.
Tony
--
Jon Smirl
jonsmirl@gmail.com
-------------------------------------------------------
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users.
Discover which products truly live up to the hype. Start reading now.
http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click
From: Antonino A. Daplas <hidden> Date: 2005-02-24 23:20:59
On Friday 25 February 2005 07:16, Jon Smirl wrote:
Can I assume then that it is acceptable and all we are waiting on is
2.6.11?
You can assume that it will get to the mm tree for a trial run, and if there
are no problems, will get pushed to Linus' tree.
Tony
PS: I will also do some testing myself this weekend.
-------------------------------------------------------
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users.
Discover which products truly live up to the hype. Start reading now.
http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click
From: James Simmons <hidden> Date: 2005-02-25 17:58:19
quoted
Can I assume then that it is acceptable and all we are waiting on is
2.6.11?
You can assume that it will get to the mm tree for a trial run, and if there
are no problems, will get pushed to Linus' tree.
Tony
PS: I will also do some testing myself this weekend.
Yeap. The process is first make patch and send to list for testing. People
comment and some changes happen. This can happen several times. Once the
patch is acceptable then it going into Andrew's tree for wider range
testing. Once Andrew determines that the patch is safe he sends it to
linus. It is a sure way to make sure the patches are of the highest
quality.
-------------------------------------------------------
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users.
Discover which products truly live up to the hype. Start reading now.
http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click
From: Jon Smirl <hidden> Date: 2005-02-25 19:35:00
On Fri, 25 Feb 2005 17:57:44 +0000 (GMT), James Simmons
[off-list ref] wrote:
Yeap. The process is first make patch and send to list for testing. People
comment and some changes happen. This can happen several times. Once the
patch is acceptable then it going into Andrew's tree for wider range
testing. Once Andrew determines that the patch is safe he sends it to
linus. It is a sure way to make sure the patches are of the highest
quality.
There is already code of mine in the kernel so I have been through the
process. Let's get the process moving on these patches so that they
will be in place by the time OLS comes around. This patch is small and
non-controversial. Let's get it started moving forward so that we can
spend time on the complex ones. The complex ones will also need to get
hammered out on LKML since they involve complicated hotplug code.
The next patch will be the sysfs one but it is not ready yet.
After that is the reset one.
Next will be secondary head support in the radeon driver.
These three will require a lot more code review.
--
Jon Smirl
jonsmirl@gmail.com
-------------------------------------------------------
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users.
Discover which products truly live up to the hype. Start reading now.
http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click
From: James Simmons <hidden> Date: 2005-02-28 20:12:36
Tony are you okay with this? I have no problem myself. I haven't tested
with various driver with various conditions yet.
On Thu, 24 Feb 2005, Jon Smirl wrote:
quoted hunk
I'm starting to get too many patches hanging around. Is there any
reason this one can't be pushed up stream? My next target would be the
sysfs patch.
--
Jon Smirl
jonsmirl@gmail.com
diff -Nru a/drivers/video/Kconfig b/drivers/video/Kconfig
fbsysfs.o modedb.o softcursor.o
+obj-$(CONFIG_FB) += fb.o
+fb-y := fbmem.o fbmon.o fbcmap.o
fbsysfs.o modedb.o softcursor.o
# Only include macmodes.o if we have FB support and are PPC
-ifeq ($(CONFIG_FB),y)
-obj-$(CONFIG_PPC) += macmodes.o
+ifneq ($(CONFIG_FB),n)
+fb-$(CONFIG_PPC) += macmodes.o
endif
+fb-objs := $(fb-y)
# Hardware specific drivers go first
obj-$(CONFIG_FB_RETINAZ3) += retz3fb.o
diff -Nru a/drivers/video/fbmem.c b/drivers/video/fbmem.c
-------------------------------------------------------
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users.
Discover which products truly live up to the hype. Start reading now.
http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click
From: Antonino A. Daplas <hidden> Date: 2005-03-01 12:33:39
On Tuesday 01 March 2005 04:12, James Simmons wrote:
Tony are you okay with this? I have no problem myself. I haven't tested
with various driver with various conditions yet.
It does have a few problems. Drivers that are bool, instead of tristate
such as vesafb, can still be selected even if fbcore is selected as module.
Tony
-------------------------------------------------------
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users.
Discover which products truly live up to the hype. Start reading now.
http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click
From: James Simmons <hidden> Date: 2005-03-01 21:05:32
There is already code of mine in the kernel so I have been through the
process. Let's get the process moving on these patches so that they
will be in place by the time OLS comes around. This patch is small and
non-controversial. Let's get it started moving forward so that we can
spend time on the complex ones. The complex ones will also need to get
hammered out on LKML since they involve complicated hotplug code.
The next patch will be the sysfs one but it is not ready yet.
After that is the reset one.
Next will be secondary head support in the radeon driver.
These three will require a lot more code review.
Have patience. Also if your patch doesn't go in time you still can demo a
patched kernel. When I first started out maintaning the fbdev layer I made
radical changes all the time. This just got people upset. Now I take my
time and make sure everything works and its clean.
-------------------------------------------------------
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users.
Discover which products truly live up to the hype. Start reading now.
http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click
From: Jon Smirl <hidden> Date: 2005-03-02 17:28:52
On Tue, 1 Mar 2005 20:31:48 +0800, Antonino A. Daplas
[off-list ref] wrote:
On Tuesday 01 March 2005 04:12, James Simmons wrote:
quoted
Tony are you okay with this? I have no problem myself. I haven't tested
with various driver with various conditions yet.
It does have a few problems. Drivers that are bool, instead of tristate
such as vesafb, can still be selected even if fbcore is selected as module.
Then it is needs (FB = y) like this...
If you leave them as checks they will be built and linked into the FB module.
[jonsmirl@jonsmirl video]$ bk diffs -u
===== Kconfig 1.76 vs edited =====
[jonsmirl@jonsmirl video]$
--
Jon Smirl
jonsmirl@gmail.com
-------------------------------------------------------
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users.
Discover which products truly live up to the hype. Start reading now.
http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click
[jonsmirl@jonsmirl video]$
--
Jon Smirl
jonsmirl@gmail.com
-------------------------------------------------------
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users.
Discover which products truly live up to the hype. Start reading now.
http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click
From: Paul Mundt <hidden> Date: 2005-03-02 17:51:04
On Wed, Mar 02, 2005 at 12:28:48PM -0500, Jon Smirl wrote:
quoted hunk
Then it is needs (FB = y) like this...
If you leave them as checks they will be built and linked into the FB module.
[jonsmirl@jonsmirl video]$ bk diffs -u
===== Kconfig 1.76 vs edited =====
There's no reason asiliantfb can't be a module, lets get that cleaned up
instead..
It would also be nice to get this fb_get_options() stuff done in a clean
way, having all these MODULE ifdefs/ifndefs here is just as ugly as when
the module_init()'s had them.
drivers/video/Kconfig | 2 +-
drivers/video/asiliantfb.c | 9 ++++++---
2 files changed, 7 insertions(+), 4 deletions(-)
===== drivers/video/Kconfig 1.74 vs edited =====
From: Jon Smirl <hidden> Date: 2005-03-02 17:55:00
Patch to allow building of the fbdev core as a module.
Signed-off-by: Jon Smirl <redacted>
--
Jon Smirl
jonsmirl@gmail.com
diff -Nru a/drivers/video/Kconfig b/drivers/video/Kconfig
fbsysfs.o modedb.o softcursor.o
+obj-$(CONFIG_FB) += fb.o
+fb-y := fbmem.o fbmon.o fbcmap.o
fbsysfs.o modedb.o softcursor.o
# Only include macmodes.o if we have FB support and are PPC
-ifeq ($(CONFIG_FB),y)
-obj-$(CONFIG_PPC) += macmodes.o
+ifneq ($(CONFIG_FB),n)
+fb-$(CONFIG_PPC) += macmodes.o
endif
+fb-objs := $(fb-y)
# Hardware specific drivers go first
obj-$(CONFIG_FB_RETINAZ3) += retz3fb.o
diff -Nru a/drivers/video/fbmem.c b/drivers/video/fbmem.c
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users.
Discover which products truly live up to the hype. Start reading now.
http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click
From: Jon Smirl <hidden> Date: 2005-03-02 23:23:54
Patch to allow building of the fbdev core as a module.
Signed-off-by: Jon Smirl <redacted>
Forgot to fix up non-x86. The algorithm is that any FB driver that is
not tristate needs (FB = y) instead of FB. It is really minor to
convert these non-module drivers to module based ones It seems to have
taken Paul about 5 minutes to convert his.
--
Jon Smirl
jonsmirl@gmail.com
diff -Nru a/drivers/video/Kconfig b/drivers/video/Kconfig
&& FB_SUN3)
+ depends on (FB = y) && ((SPARC32 || SPARC64) && FB_SBUS || (SUN3 ||
SUN3X) && FB_SUN3)
help
This is the frame buffer device driver for the BWtwo frame buffer.
config FB_CG3
bool "CGthree support"
- depends on FB && ((SPARC32 || SPARC64) && FB_SBUS || (SUN3 || SUN3X)
&& FB_SUN3)
+ depends on (FB = y) && ((SPARC32 || SPARC64) && FB_SBUS || (SUN3 ||
SUN3X) && FB_SUN3)
help
This is the frame buffer device driver for the CGthree frame buffer.
config FB_CG6
bool "CGsix (GX,TurboGX) support"
- depends on FB && ((SPARC32 || SPARC64) && FB_SBUS || (SUN3 || SUN3X)
&& FB_SUN3)
+ depends on (FB = y) && ((SPARC32 || SPARC64) && FB_SBUS || (SUN3 ||
SUN3X) && FB_SUN3)
help
This is the frame buffer device driver for the CGsix (GX, TurboGX)
frame buffer.
@@ -436,7 +436,7 @@ config FB_EPSON1355 bool "Epson 1355 framebuffer support"- depends on FB && (SUPERH || ARCH_CEIVA)+ depends on (FB = y) && (SUPERH || ARCH_CEIVA) help Build in support for the SED1355 Epson Research Embedded RAMDAC LCD/CRT Controller (since redesignated as the S1D13505) as a
@@ -953,11 +953,11 @@ config FB_AU1100 bool "Au1100 LCD Driver"- depends on FB && EXPERIMENTAL && PCI && MIPS && MIPS_PB1100=y+ depends on (FB = y) && EXPERIMENTAL && PCI && MIPS && MIPS_PB1100=y config FB_SBUS bool "SBUS and UPA framebuffers"- depends on FB && (SPARC32 || SPARC64)+ depends on (FB = y) && (SPARC32 || SPARC64) help Say Y if you want support for SBUS or UPA based frame buffer device.
@@ -1016,21 +1016,21 @@ config FB_PMAG_AA bool "PMAG-AA TURBOchannel framebuffer support"- depends on FB && MACH_DECSTATION && TC+ depends on (FB = y) && MACH_DECSTATION && TC help Support for the PMAG-AA TURBOchannel framebuffer card (1280x1024x1) used mainly in the MIPS-based DECstation series. config FB_PMAG_BA bool "PMAG-BA TURBOchannel framebuffer support"- depends on FB && MACH_DECSTATION && TC+ depends on (FB = y) && MACH_DECSTATION && TC help Support for the PMAG-BA TURBOchannel framebuffer card (1024x864x8) used mainly in the MIPS-based DECstation series. config FB_PMAGB_B bool "PMAGB-B TURBOchannel framebuffer support"- depends on FB && MACH_DECSTATION && TC+ depends on (FB = y) && MACH_DECSTATION && TC help Support for the PMAGB-B TURBOchannel framebuffer card used mainly in the MIPS-based DECstation series. The card is currently only
@@ -1038,7 +1038,7 @@ config FB_MAXINE bool "Maxine (Personal DECstation) onboard framebuffer support"- depends on FB && MACH_DECSTATION && TC+ depends on (FB = y) && MACH_DECSTATION && TC help Support for the onboard framebuffer (1024x768x8) in the Personal DECstation series (Personal DECstation 5000/20, /25, /33, /50,
@@ -1046,7 +1046,7 @@ config FB_TX3912 bool "TMPTX3912/PR31700 frame buffer support"- depends on FB && NINO+ depends on (FB = y) && NINO help The TX3912 is a Toshiba RISC processor based on the MIPS 3900 core see <http://www.toshiba.com/taec/components/Generic/risc/tx3912.htm>.
fbsysfs.o modedb.o softcursor.o
+obj-$(CONFIG_FB) += fb.o
+fb-y := fbmem.o fbmon.o fbcmap.o
fbsysfs.o modedb.o softcursor.o
# Only include macmodes.o if we have FB support and are PPC
-ifeq ($(CONFIG_FB),y)
-obj-$(CONFIG_PPC) += macmodes.o
+ifneq ($(CONFIG_FB),n)
+fb-$(CONFIG_PPC) += macmodes.o
endif
+fb-objs := $(fb-y)
# Hardware specific drivers go first
obj-$(CONFIG_FB_RETINAZ3) += retz3fb.o
diff -Nru a/drivers/video/fbmem.c b/drivers/video/fbmem.c
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users.
Discover which products truly live up to the hype. Start reading now.
http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click