Fix spurious error return in FBIO_RADEON_SET_MIRROR (fwd)
From: Geert Uytterhoeven <geert@linux-m68k.org>
Date: 2005-01-26 12:37:41
---------- Forwarded message ---------- Date: Wed, 26 Jan 2005 02:05:43 +0100 From: Andreas Schwab <redacted> To: linuxppc-dev@ozlabs.org Subject: Fix spurious error return in FBIO_RADEON_SET_MIRROR FBIO_RADEON_SET_MIRROR always returns with -EINVAL even if successful due to an inappropriate fall-through. Signed-off-by: Andreas Schwab <redacted>
--- linux-2.6.10/drivers/video/aty/radeon_base.c.~1~ 2004-12-29 20:17:12.000000000 +0100
+++ linux-2.6.10/drivers/video/aty/radeon_base.c 2005-01-26 01:48:17.000000000 +0100@@ -911,7 +911,7 @@ static int radeonfb_ioctl (struct inode OUTREG(CRTC_EXT_CNTL, tmp); - break; + return 0; case FBIO_RADEON_GET_MIRROR: if (!rinfo->is_mobility) return -EINVAL;
Andreas. -- Andreas Schwab, SuSE Labs, schwab@suse.de SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 "And now for something completely different." _______________________________________________ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev