# Re: \[2.6 patch\] cyber2000fb.c: misc cleanups

- List: linux-fbdev
- 2 messages, 2 authors
- Page: https://ratatoskr.run/linux-fbdev/2004/11/689534/t

## Re: \[2.6 patch\] cyber2000fb.c: misc cleanups

- From: Russell King \<hidden\>
- Date: 2004-11-22 00:06:38 
- Message: https://ratatoskr.run/linux-fbdev/2004/11/689534.md

```text
On Sun, Nov 21, 2004 at 08:56:13PM +0000, Christoph Hellwig wrote:
> On Sun, Nov 21, 2004 at 08:47:52PM +0000, Russell King wrote:
> > On Sun, Nov 21, 2004 at 04:36:14PM +0100, Adrian Bunk wrote:
> > > The patch below ncludes the following cleanups for 
> > > drivers/video/cyber2000fb.c:
> > > - remove five EXPORT_SYMBOL'ed but completely unused functions
> > > - make some needlessly global code static
> > 
> > These are used by the video capture code which isn't merged, but is
> > used by people.  Rejected.
> 
> If people use the code it should get merged or Adrian has all reasons to
> remove or #if 0 the code.

Sigh, if that's what you want to do and place extra burden on me,
that's fine.  Don't expect me to co-operate with you next time you
want me to do something though, no matter how important you feel it
is.  Works both ways.

-- 
Russell King
 Linux kernel    2.6 ARM Linux   - http://www.arm.linux.org.uk/
 maintainer of:  2.6 PCMCIA      - http://pcmcia.arm.linux.org.uk/
                 2.6 Serial core
```

## Re: \[2.6 patch\] cyber2000fb.c: misc cleanups

- From: Adrian Bunk \<hidden\>
- Date: 2004-11-22 00:11:03 
- Message: https://ratatoskr.run/linux-fbdev/2004/11/689535.md

```text
On Mon, Nov 22, 2004 at 12:04:13AM +0000, Russell King wrote:
> On Sun, Nov 21, 2004 at 08:56:13PM +0000, Christoph Hellwig wrote:
> > On Sun, Nov 21, 2004 at 08:47:52PM +0000, Russell King wrote:
> > > On Sun, Nov 21, 2004 at 04:36:14PM +0100, Adrian Bunk wrote:
> > > > The patch below ncludes the following cleanups for 
> > > > drivers/video/cyber2000fb.c:
> > > > - remove five EXPORT_SYMBOL'ed but completely unused functions
> > > > - make some needlessly global code static
> > > 
> > > These are used by the video capture code which isn't merged, but is
> > > used by people.  Rejected.
> > 
> > If people use the code it should get merged or Adrian has all reasons to
> > remove or #if 0 the code.
> 
> Sigh, if that's what you want to do and place extra burden on me,
> that's fine.  Don't expect me to co-operate with you next time you
> want me to do something though, no matter how important you feel it
> is.  Works both ways.

Where is this video capture code, and why can't it be included in the 
kernel?

cu
Adrian

BTW: It's not my intention to piss off maintainers.

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed
```
