# Re: \[2.6 patch\] cyber2000fb.c: misc cleanups

- List: linux-fbdev
- 2 messages, 2 authors
- Page: https://ratatoskr.run/linux-fbdev/2004/11/689489/t

## Re: \[2.6 patch\] cyber2000fb.c: misc cleanups

- From: Russell King \<hidden\>
- Date: 2004-11-21 20:47:59 
- Message: https://ratatoskr.run/linux-fbdev/2004/11/689489.md

```text
On Sun, Nov 21, 2004 at 04:36:14PM +0100, Adrian Bunk wrote:
> The patch below ncludes the following cleanups for 
> drivers/video/cyber2000fb.c:
> - remove five EXPORT_SYMBOL'ed but completely unused functions
> - make some needlessly global code static

These are used by the video capture code which isn't merged, but is
used by people.  Rejected.

-- 
Russell King
 Linux kernel    2.6 ARM Linux   - http://www.arm.linux.org.uk/
 maintainer of:  2.6 PCMCIA      - http://pcmcia.arm.linux.org.uk/
                 2.6 Serial core
```

## Re: \[2.6 patch\] cyber2000fb.c: misc cleanups

- From: Christoph Hellwig \<hch@infradead.org\>
- Date: 2004-11-21 20:56:19 
- Message: https://ratatoskr.run/linux-fbdev/2004/11/689492.md

```text
On Sun, Nov 21, 2004 at 08:47:52PM +0000, Russell King wrote:
> On Sun, Nov 21, 2004 at 04:36:14PM +0100, Adrian Bunk wrote:
> > The patch below ncludes the following cleanups for 
> > drivers/video/cyber2000fb.c:
> > - remove five EXPORT_SYMBOL'ed but completely unused functions
> > - make some needlessly global code static
> 
> These are used by the video capture code which isn't merged, but is
> used by people.  Rejected.

If people use the code it should get merged or Adrian has all reasons to
remove or #if 0 the code.
```
