# Re: \[Linux-fbdev-devel\] Re: \[PATCH\] fbdev: Fix IO access in rivafb

- From: Linus Torvalds \<torvalds@osdl.org\>
- Date: 2004-11-08 22:26:10 
- List: linux-fbdev
- Page: https://ratatoskr.run/linux-fbdev/2004/11/685835
- Thread: https://ratatoskr.run/lkml/2004/11/685587/t.md

```text


On Tue, 9 Nov 2004, Antonino A. Daplas wrote:
> 
> In big endian machines, the read*/write* accessors do a byteswap for an
> inherently little endian PCI bus.  However, rivafb puts the hardwire in big
> endian register access, thus the byteswap is not needed. So for 16- and
> 32-bit access, instead of read*/write*, use __raw_read*/__raw_write* for all
> archs.

Ok, applied with some further simplifications (use "void __iomem *" and 
suddenly those /2 and /4 just go away - also use __raw_xxxx for the 
single-byte versions to be consistent).

		Linus
```
