# Re: \[Linux-fbdev-devel\] Re: \[PATCH\] fbdev: Fix IO access in rivafb

- From: Linus Torvalds \<torvalds@osdl.org\>
- Date: 2004-11-08 20:13:33 
- List: linux-fbdev
- Page: https://ratatoskr.run/linux-fbdev/2004/11/685791
- Thread: https://ratatoskr.run/lkml/2004/11/685587/t.md

```text


On Tue, 9 Nov 2004, Antonino A. Daplas wrote:
> 
> In big endian machines, the read*/write* accessors do a byteswap for an
> inherently little endian PCI bus.  However, rivafb puts the hardwire in big
> endian register access, thus the byteswap is not needed. So, instead of
> read*/write*, use __raw_read*/__raw_write*.

This fix should make the #ifdef CONFIG_PCC entirely superfluous afaik. 

The thing is, once riva does its HW accesses right, the special cases just 
go away. There's a reason we have abstractions.. 

Does anybody have the hardware to test with?

		Linus
```
